Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: top bar not centered when on-premises backend is visible [WPB-9383] #3028

Merged
merged 2 commits into from
May 23, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented May 22, 2024

BugWPB-9383 [Android] Login screen misaligned


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Top bar title and subtitle are not centered when there's an on-premises backend info visible.

Causes (Optional)

For CenterAlignedTopAppBar, Android calculates the position of title's composable according to its width, which means that this composable shouldn't have fillMaxWidth or fillMaxSize set, otherwise it will take the entire space and won't center it properly because it won't be possible.

Solutions

Remove fillMaxWidth from ServerTitle - it's used on the top bar and this modifier is absolutely not needed there, it will work the same without it.

Testing

How to Test

Open login screen and deep link into a custom backend.

Attachments (Optional)

Before After
Screenshot_20240522_161249 Screenshot_20240522_164909

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk changed the title fix: top bar not centered when on-premises backend is visible fix: top bar not centered when on-premises backend is visible [WPB-9383] May 22, 2024
@saleniuk saleniuk requested review from a team, yamilmedina, alexandreferris, vitorhugods, mchenani and ohassine and removed request for a team May 22, 2024 16:03
Copy link
Contributor

github-actions bot commented May 22, 2024

Test Results

927 tests   927 ✅  13m 15s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 7ac40d4.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4918 succeeded.

The build produced the following APK's:

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4927 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit b0c9367 into release/candidate May 23, 2024
18 checks passed
@saleniuk saleniuk deleted the fix/center-aligned-top-bar branch May 23, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants