-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: top bar not centered when on-premises backend is visible [WPB-9383] #3028
Conversation
Test Results927 tests 927 ✅ 13m 15s ⏱️ Results for commit 7ac40d4. ♻️ This comment has been updated with latest results. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4918 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4927 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Top bar title and subtitle are not centered when there's an on-premises backend info visible.
Causes (Optional)
For
CenterAlignedTopAppBar
, Android calculates the position of title's composable according to its width, which means that this composable shouldn't havefillMaxWidth
orfillMaxSize
set, otherwise it will take the entire space and won't center it properly because it won't be possible.Solutions
Remove
fillMaxWidth
fromServerTitle
- it's used on the top bar and this modifier is absolutely not needed there, it will work the same without it.Testing
How to Test
Open login screen and deep link into a custom backend.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.