fix: top bar not centered when on-premises backend is visible [WPB-9383] 🍒

[github-actions]

WPB-9383 [Android] Login screen misaligned

This PR was automatically cherry-picked based on the following PR:

• fix: top bar not centered when on-premises backend is visible [WPB-9383] #3028

Original PR description:

---

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Top bar title and subtitle are not centered when there's an on-premises backend info visible.

Causes (Optional)

For CenterAlignedTopAppBar, Android calculates the position of title's composable according to its width, which means that this composable shouldn't have fillMaxWidth or fillMaxSize set, otherwise it will take the entire space and won't center it properly because it won't be possible.

Solutions

Remove fillMaxWidth from ServerTitle - it's used on the top bar and this modifier is absolutely not needed there, it will work the same without it.

Testing

How to Test

Open login screen and deep link into a custom backend.

Attachments (Optional)

Before	After

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.30%. Comparing base (d26b742) to head (8f0e662).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3029      +/-   ##
===========================================
+ Coverage    44.25%   44.30%   +0.04%     
===========================================
  Files          448      448              
  Lines        14519    14517       -2     
  Branches      2495     2493       -2     
===========================================
+ Hits          6426     6432       +6     
+ Misses        7391     7382       -9     
- Partials       702      703       +1     

see 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f8a2f...8f0e662. Read the comment docs.

[github-actions]

Test Results

930 tests   930 ✅  8m 52s ⏱️
124 suites    0 💤
124 files      0 ❌

Results for commit 8f0e662.

♻️ This comment has been updated with latest results.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 4933 succeeded.

The build produced the following APK's:

• com.wire.android-v4.8.0(9748592)(9748592)-staging-compat.apk

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 4945 succeeded.

The build produced the following APK's:

• com.wire.android-v4.8.0(9749974)(9749974)-staging-compat.apk