feat: grouping message dates (WPB-1733) #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alexandreferris <[email protected]>
…essageDateTimeGroup Signed-off-by: alexandreferris <[email protected]>
…s to be shown Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/messages/item/RegularMessageItem.kt
Test Results923 tests 923 ✅ 12m 45s ⏱️ Results for commit d060f5c. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4585 succeeded. The build produced the following APK's: |
alexandreferris
requested review from
a team,
yamilmedina,
MohamadJaara,
Garzas,
ohassine,
saleniuk,
vitorhugods and
mchenani
and removed request for
a team
Garzas
requested changes
May 6, 2024
app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationScreen.kt
Show resolved
Hide resolved
Garzas
approved these changes
May 6, 2024
yamilmedina
approved these changes
May 6, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 6, 2024
Signed-off-by: alexandreferris <[email protected]>
6 tasks
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4613 succeeded. The build produced the following APK's: |
6 tasks
6 tasks
echoes-hq
bot
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Previous implementation of grouping message dates had a different design than expected
Solutions
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
- Now (just send/receive a message)
- Within 30 Minutes (let a sent/received message pass at least 1min)
- Today (30 min < message < Yesterday)
- Yesterday (Before Yesterday < message < Today)
- Within Week (7 days ago < message < Yesterday)
- Not Within Week but Same Year (01.01.this_year < message < 7 days ago)
- Other (any message that is not from this year)
Attachments (Optional)
References
https://developer.android.com/reference/android/icu/text/RelativeDateTimeFormatter
https://android.googlesource.com/platform/prebuilts/fullsdk/sources/android-31/+/refs/heads/androidx-core-core-google-shortcuts-release/android/text/format/RelativeDateTimeFormatter.java
https://developer.android.com/reference/android/text/format/DateUtils