Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: group messages date | design changes (WPB-1733) #2980

Merged
merged 9 commits into from
May 8, 2024
Merged

fix: group messages date | design changes (WPB-1733) #2980

merged 9 commits into from
May 8, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented May 6, 2024 •
edited by github-actions bot
Loading

StoryWPB-1733 Timestamps – grouping functionality for dates

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Edge case when message is the first and only message
  • Edge case when its the last message
  • Design on divider margins

Solutions

  • Some design changes (margin on divider)
  • Addition of edge case when its only 1 message or the last message
  • Addition of 45min gap handling
  • Remove date from the right side of Message Item (instead of [date|time] -> [time])

Dependencies (Optional)

Needs releases with:

Screenshot 2024-05-06 at 12 00 33 Screenshot 2024-05-06 at 12 00 08

@alexandreferris alexandreferris changed the base branch from develop to release/candidate May 6, 2024 15:25
@wireapp wireapp deleted a comment from pull-request-size bot May 6, 2024
@AndroidBob
Copy link
Collaborator

Build 4634 succeeded.

The build produced the following APK's:

@alexandreferris alexandreferris added the WIP Work In Progress label May 7, 2024
@alexandreferris
fix: add function to verify if current and previous date are more tha…
0a076c4 
…n 45 minutes apart or if they are different days

Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
fix: usage of new function to verify for 45min gap
d4df28c 
Signed-off-by: alexandreferris <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024 •
edited
Loading

Test Results

927 tests   927 ✅  9m 33s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 89a75a1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4655 succeeded.

The build produced the following APK's:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4663 succeeded.

The build produced the following APK's:

@alexandreferris alexandreferris removed WIP Work In Progress DO NOT MERGE labels May 8, 2024
@yamilmedina yamilmedina enabled auto-merge (squash) May 8, 2024 08:07
@yamilmedina yamilmedina merged commit e33275b into release/candidate May 8, 2024
11 of 12 checks passed
@yamilmedina yamilmedina deleted the fix/group_messages_date branch May 8, 2024 08:12
github-actions bot pushed a commit that referenced this pull request May 8, 2024
@alexandreferris @vitorhugods @github-actions
fix: group messages date | design changes (WPB-1733) (#2980)
eb30213 
Signed-off-by: alexandreferris <[email protected]>
Co-authored-by: Vitor Hugo Schwaab <[email protected]>
@github-actions github-actions bot mentioned this pull request May 8, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohassine ohassine ohassine approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

Assignees

@alexandreferris alexandreferris

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandreferris @AndroidBob @vitorhugods @ohassine @yamilmedina