-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get identities only for newly emitted members [WPB-8753] #2942
Conversation
Test Results823 tests 823 ✅ 13m 58s ⏱️ Results for commit 5a497dd. ♻️ This comment has been updated with latest results. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4485 succeeded. The build produced the following APK's: |
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4486 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
ANR when trying to get user or device identities.
Solutions
To limit the amount of user identities fetched at a given time, keep the already fetched values using
scan
and only fetch user identities for newly emitted visible members.Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Navigate: group conversation -> details -> participants -> user profile -> 1:1 conversation -> back or conversation details
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.