Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get identities only for newly emitted members [WPB-8753] #2942

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Apr 26, 2024

BugWPB-8753 [Android] Crash when going left menu from first time opened 1:1 conv


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

ANR when trying to get user or device identities.

Solutions

To limit the amount of user identities fetched at a given time, keep the already fetched values using scan and only fetch user identities for newly emitted visible members.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Navigate: group conversation -> details -> participants -> user profile -> 1:1 conversation -> back or conversation details


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Apr 26, 2024

Test Results

823 tests   823 ✅  13m 58s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit 5a497dd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4485 succeeded.

The build produced the following APK's:

Copy link
Contributor

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/candidate This PR
91be23a81d973fdc30df33e42c88c531b965eb6a 18742dfc83234db632c707536d29c48e2d821672

Is this intentional?

@saleniuk saleniuk enabled auto-merge (squash) April 26, 2024 13:45
@saleniuk saleniuk disabled auto-merge April 26, 2024 13:52
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4486 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit 5638df4 into release/candidate Apr 26, 2024
13 checks passed
@saleniuk saleniuk deleted the fix/mlsclient-getidentities-anrs branch April 26, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants