-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get identities only for newly emitted members [WPB-8753] #2944
fix: get identities only for newly emitted members [WPB-8753] #2944
Conversation
Build 4489 failed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2944 +/- ##
===========================================
+ Coverage 44.17% 44.20% +0.03%
===========================================
Files 443 443
Lines 14341 14350 +9
Branches 2468 2469 +1
===========================================
+ Hits 6335 6344 +9
Misses 7313 7313
Partials 693 693
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
…dentities-anrs-cherry-pick
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4496 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
app/src/main/kotlin/com/wire/android/ui/home/conversations/details/participants/usecase/ObserveParticipantsForConversationUseCase.kt
app/src/test/kotlin/com/wire/android/ui/home/conversations/details/participants/usecase/ObserveParticipantsForConversationUseCaseTest.kt
kalium
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
ANR when trying to get user or device identities.
Solutions
To limit the amount of user identities fetched at a given time, keep the already fetched values using and only fetch user identities for newly emitted visible members.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Navigate: group conversation -> details -> participants -> user profile -> 1:1 conversation -> back or conversation details
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References