Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get identities only for newly emitted members [WPB-8753] #2944

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Apr 26, 2024

BugWPB-8753 [Android] Crash when going left menu from first time opened 1:1 conv

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
app/src/main/kotlin/com/wire/android/ui/home/conversations/details/participants/usecase/ObserveParticipantsForConversationUseCase.kt
app/src/test/kotlin/com/wire/android/ui/home/conversations/details/participants/usecase/ObserveParticipantsForConversationUseCaseTest.kt
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

ANR when trying to get user or device identities.

Solutions

To limit the amount of user identities fetched at a given time, keep the already fetched values using and only fetch user identities for newly emitted visible members.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Navigate: group conversation -> details -> participants -> user profile -> 1:1 conversation -> back or conversation details


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Apr 26, 2024
Copy link
Contributor

github-actions bot commented Apr 26, 2024

Test Results

915 tests  +3   915 ✅ +3   14m 28s ⏱️ -48s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit a9a0f5b. ± Comparison against base commit d4e1cd6.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 4489 failed.

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, borichellow, MohamadJaara and Garzas and removed request for a team April 26, 2024 15:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.20%. Comparing base (d4e1cd6) to head (a9a0f5b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2944      +/-   ##
===========================================
+ Coverage    44.17%   44.20%   +0.03%     
===========================================
  Files          443      443              
  Lines        14341    14350       +9     
  Branches      2468     2469       +1     
===========================================
+ Hits          6335     6344       +9     
  Misses        7313     7313              
  Partials       693      693              
Files Coverage Δ
...ecase/ObserveParticipantsForConversationUseCase.kt 91.30% <100.00%> (+2.11%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e1cd6...a9a0f5b. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk enabled auto-merge April 26, 2024 15:31
@saleniuk saleniuk disabled auto-merge April 26, 2024 15:56
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk added this pull request to the merge queue Apr 26, 2024
@AndroidBob
Copy link
Collaborator Author

Build 4496 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit ca21b3a Apr 26, 2024
13 checks passed
@saleniuk saleniuk deleted the fix/mlsclient-getidentities-anrs-cherry-pick branch April 26, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants