Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): set user display name correctly for the certificate downloaded file (WPB-8606) #2941

Closed
wants to merge 134 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
134 commits
Select commit Hold shift + click to select a range
7496480
fix: add correct colors for dark mode when recording audio (WPB-4534)…
alexandreferris Jan 21, 2024
381f99b
chore: update source location strings english (#2602)
yamilmedina Jan 22, 2024
5b1a77f
fix: sharing location crash when device location off (WPB-6182) (#2601)
yamilmedina Jan 22, 2024
e455480
fix: original image path was used images when sharing from share exte…
MohamadJaara Jan 22, 2024
d16ce74
ci: cherry pick gh action result in bot as auther (#2608)
MohamadJaara Jan 22, 2024
5ddbbe0
fix: changes to hopefully improve startup and ANRs [WPB-6048] (#2607)
saleniuk Jan 23, 2024
97eacae
feat: improve enrollment dialog (WPB-4372) (#2610)
yamilmedina Jan 23, 2024
c669dce
test: add sharing location coverage for viewmodel (#2620)
yamilmedina Jan 25, 2024
de6b960
chore: source base strings new for custom dialog deeplink
yamilmedina Jan 25, 2024
da8b5ed
chore: update localization strings via Crowdin (rc) (#2628)
AndroidBob Jan 25, 2024
4a50f65
feat(e2ei): respect e2ei during login and mls client creation (WPB-58…
mchenani Jan 26, 2024
847af47
chore: remove un-needed changes (#2634)
mchenani Jan 26, 2024
b62d100
feat: Show a dialog when current client's certificate is revoked (WPB…
ohassine Jan 26, 2024
ea851f3
chore: Update kalium reference (RC) (#2639)
ohassine Jan 26, 2024
42c5830
fix: setting items clickable area [WPB-6225] (#2643)
saleniuk Jan 31, 2024
51c465e
fix: logging level does not reflect in datadog (#2645)
yamilmedina Jan 31, 2024
0c41348
fix: self-deleting msg in doze mode on ConversationScreen [WPB-5894] …
saleniuk Jan 31, 2024
9350830
fix: not possible to search for services [WPB-5943] (#2648)
MohamadJaara Jan 31, 2024
0bb42cd
chore: kalium ref
yamilmedina Feb 1, 2024
8f2f1b6
ci: fix cherry pick action when last commit message contains special …
MohamadJaara Feb 2, 2024
bfaa191
fix: make SelfDeletionTimerTest unit instead of instrumented (#2657)
saleniuk Feb 2, 2024
22bd1b4
fix: remove trim of spaces when searching for messages inside a conve…
alexandreferris Feb 5, 2024
5daa694
chore(ci): base64 encoding adding a new line after 76 char (#2666)
MohamadJaara Feb 6, 2024
9a2b353
fix: persistent audio state, observe senderId, edit deleted message c…
Garzas Feb 7, 2024
fd1b0e2
chore: remove jacoco and migrate to kover (ACOL-139) (#2670)
yamilmedina Feb 7, 2024
a05a3ce
fix: crash when uploading avatar [WPB-5965] (#2673)
saleniuk Feb 7, 2024
184a051
fix: add fully qualified handle for external results (WPB-6256) (#2676)
yamilmedina Feb 8, 2024
6b55105
chore: update kalium
MohamadJaara Feb 9, 2024
8dc5948
feat: support remote search by handle (#2647)
MohamadJaara Feb 9, 2024
6f61248
fix: text highlight colors [WPB-5940] (#2680)
saleniuk Feb 9, 2024
876f5da
fix(e2ei): remove E2EI shield from remove device screen (WPB-6519) (#…
mchenani Feb 12, 2024
7914307
fix: NotificationChannelGroup crash (WPB-6233) (#2687)
borichellow Feb 13, 2024
ceb0052
fix: serverConfig and notification crashes right after user becomes i…
saleniuk Feb 13, 2024
6f7e5ca
fix: welcome screen large screen [WPB-6427] (#2690)
Garzas Feb 13, 2024
ea33f80
fix(e2ei): remove E2EI shield and buttons if it's disabled on your te…
mchenani Feb 13, 2024
f3d03c3
fix: 2FA support dark mode (#2697)
borichellow Feb 13, 2024
71172b7
fix: message background highlight colors [WPB-5940] (#2693)
saleniuk Feb 13, 2024
2fb0e05
fix: long click on deleted message (WPB-6290) (#2696)
alexandreferris Feb 13, 2024
a6b9a5f
fix: Use idp client id from remote (WPB-6494) (#2683)
ohassine Feb 13, 2024
275ba25
fix: crash when answering a call (WPB-6183) - cherrypick (#2705)
ohassine Feb 14, 2024
2ab8863
feat: allow http calls when checking Certificate Revocation List (WPB…
ohassine Feb 14, 2024
1f4d3ab
chore: update kalium reference
ohassine Feb 14, 2024
b9c734b
feat: fetch 2000 team members dring sync [WPB-6483] (#2704)
MohamadJaara Feb 15, 2024
d8a31c8
fix: remove browser allow list and skip of https check (WPB-6609) (#2…
alexandreferris Feb 15, 2024
54530b7
fix: MLS degraded dialogs [WPB-6607] (#2712)
borichellow Feb 15, 2024
5c76287
chore: update kalium
MohamadJaara Feb 16, 2024
c27c5cf
fix: leaking UI context GetE2EICertificateUseCase (WPB-6648) (#2713)
alexandreferris Feb 16, 2024
1a2034e
fix: show connection request with unavailable name [WPB-6247] (#2716)
Garzas Feb 16, 2024
b9a85f3
chore: update kalium
MohamadJaara Feb 19, 2024
996103b
feat: update place holder name for call participants
MohamadJaara Feb 20, 2024
f4fef2f
feat: implement use case to get default conversation creation protoc…
alexandreferris Feb 21, 2024
1e9c1e9
chore: update kalium
MohamadJaara Feb 22, 2024
5cc138f
chore: add git commit hash to external logger (#2729)
MohamadJaara Feb 22, 2024
16b4cdb
fix(e2ei): error handling (WPB-6271) (#2721)
mchenani Feb 23, 2024
1ab45c9
chore: remove unwanted log
MohamadJaara Feb 23, 2024
63fd841
chore: fix tag logging (#2730)
vitorhugods Feb 23, 2024
e11de8a
chore: fix dev tag logging
MohamadJaara Feb 23, 2024
c9dd591
chore: add structured logs to location and fix permission handling (W…
yamilmedina Feb 23, 2024
8e38267
chore: update app version
MohamadJaara Feb 23, 2024
295d618
chore: fix tag logging for internal and staging flavors (#2739)
saleniuk Feb 26, 2024
fadfac3
fix: release: Enrolling E2EI crash [WPB-6788] (#2728)
borichellow Feb 27, 2024
30b8039
fix(e2ei): force login to idp to update certificate (WPB-6877) (#2742)
mchenani Feb 27, 2024
617beeb
feat: Remove third party library for certificate decoding (WPB-6765) …
ohassine Feb 28, 2024
88c2846
chore: update kalium reference
ohassine Feb 28, 2024
85593a6
fix: crash about persistent websocket being started from background […
saleniuk Feb 28, 2024
d277d19
fix: Do not show waiting network in CertDetails screen (RC) (WPB-6638…
borichellow Feb 28, 2024
1d39d4a
fix: some end points are not routed through the proxy server 4.6 (#2723)
MohamadJaara Feb 29, 2024
a5ab875
fix(e2ei): loading e2ei state during the app initialisation (#2664)
mchenani Mar 1, 2024
1265e6b
fix: unexpected scrolling on selected message [WPB-6932] (#2753)
Garzas Mar 1, 2024
f7a2186
chore: update kalium
MohamadJaara Mar 1, 2024
79b7652
chore: update app version
MohamadJaara Mar 2, 2024
f3b506a
chore: update kalium
MohamadJaara Mar 4, 2024
332bb41
fix: e2e webview close [WPB-6788] (#2762)
Garzas Mar 4, 2024
98d654e
fix: network screen is empty on graphene os (#2760)
MohamadJaara Mar 4, 2024
998be7d
chore: update kalium
MohamadJaara Mar 5, 2024
b40bf8b
chore: update kalium
MohamadJaara Mar 5, 2024
0bf115b
chore: update kalium
MohamadJaara Mar 6, 2024
3db6178
chore: explicitly restrict the app to be installed internally (#2768)
MohamadJaara Mar 6, 2024
a1dae98
chore: update kalium
MohamadJaara Mar 6, 2024
3dae65c
fix: persistent ws not reflected in UI (WPB-7020) (#2770)
yamilmedina Mar 6, 2024
e4b3623
chore: update kalium
MohamadJaara Mar 7, 2024
e2aeaad
fix: user pic is not editable for scim users (#2759)
MohamadJaara Mar 8, 2024
ccaabff
chore: update kalium
MohamadJaara Mar 11, 2024
611e574
fix: Remove autologin in Keycloak in E2EI [WPB-7061] (#2774)
borichellow Mar 11, 2024
2394e27
fix: breaking changes from kalium (#2778)
MohamadJaara Mar 11, 2024
b0e5621
chore: update kalium
MohamadJaara Mar 11, 2024
82fceb0
fix(calling): microphone restricted when the app goes into background…
ohassine Mar 11, 2024
2420b87
fix: list in markdown quote [WPB-6622] (#2781)
Garzas Mar 12, 2024
e5f2d5c
fix: Localised DateFormat in device info (#2783)
borichellow Mar 12, 2024
d2185f9
chore: update kalium
MohamadJaara Mar 12, 2024
0fec080
fix: adding federated members to groups
MohamadJaara Mar 12, 2024
8bd9040
chore: remove duplicated enroll e2ei use case (#2788)
MohamadJaara Mar 13, 2024
efe1ca6
chore: update kalium
MohamadJaara Mar 13, 2024
b962aeb
fix: Create Group protocol not editable anymore [WPB-7109] (#2790)
borichellow Mar 14, 2024
d6e94cc
chore: bump app version to 4.6.3
MohamadJaara Mar 14, 2024
ce5094b
fix: periodic checks for ws service to start if necessary (WPB-6343) …
yamilmedina Mar 14, 2024
98a0bf1
chore: update kalium
MohamadJaara Mar 14, 2024
f3dfb12
chore: update kalium
MohamadJaara Mar 15, 2024
0693f1c
feat: add a crl revocation list to debug screen (#2793)
MohamadJaara Mar 21, 2024
2d37528
chore: update kalium
MohamadJaara Mar 22, 2024
4dc00e6
fix: misleading dialog copy when certificate enrolling fails (WPB-712…
alexandreferris Mar 22, 2024
6833d5f
fix: Calling video not streamed when enabling camera on preview scree…
ohassine Mar 25, 2024
1a40109
fix: Some workers not running when persistent websocket is enabled (W…
ohassine Mar 25, 2024
bfc274c
feat: adding fdroid flavor to build without GMS and Firebase (WPB-279…
MohamadJaara Mar 25, 2024
abd7f34
feat: add fdroid to jenkins script (#2814)
MohamadJaara Mar 25, 2024
4efd892
fix: update last read message on conversation opening [WPB-7208] (#2819)
Garzas Mar 26, 2024
b4f213f
fix: disable name change when e2ei is enabled (#2825)
MohamadJaara Mar 27, 2024
887b2e2
feat: enable encrypted proteus storage for internal builds (#2833)
MohamadJaara Mar 28, 2024
bd360e1
feat: add avs and cc version to debug screen (#2830)
MohamadJaara Apr 2, 2024
afb374b
refactor: simplify dependency version resource generation (#2849)
vitorhugods Apr 3, 2024
23d925e
chore: update kalium
MohamadJaara Apr 4, 2024
ac7786b
fix: crash when checking audio file size limit (WPB-5961) (#2757) (#2…
MohamadJaara Apr 4, 2024
272c7ee
fix: lintVitalAnalyze failing because of dependenciesVersionTask (#2858)
MohamadJaara Apr 5, 2024
aeff098
fix: RevokedCertificate dialog undismissable RC [WPB-7226] (#2854)
borichellow Apr 5, 2024
d67bf85
fix: Remove NotificationDot for some notifications RC (#2856)
borichellow Apr 5, 2024
13d1705
fix: crash on GrapheneOS when downloading certificate (WPB-7407) (#2864)
alexandreferris Apr 5, 2024
8565a3e
fix: close properly keyboard in conversation screen [WPB-7630] (#2872)
Garzas Apr 8, 2024
ec371a7
fix: read conversation on short list [WPB-7432] (#2876)
Garzas Apr 9, 2024
8366a0e
fix: Display verified E2EI icon other user devices list [WPB-6974] (#…
borichellow Apr 9, 2024
3e29464
chore: update kalium
MohamadJaara Apr 9, 2024
bc12ea5
fix: misleading e2ei certificate error dialog (WPB-7129) (#2883)
alexandreferris Apr 11, 2024
19bce82
fix: remove dot from title string (#2887)
alexandreferris Apr 12, 2024
844f58f
fix: startup crash with fdroid [WPB-7286] (#2845)
e-lisa Apr 12, 2024
480a5a6
fix: wrong color of fdroid app icon (WPB-7287) (#2886)
e-lisa Apr 12, 2024
fb657e9
fix: error in deciding whether the current build should use open sour…
MohamadJaara Apr 15, 2024
2d5066d
fix: Fetch MLS status on every conversation opening [WPB-8610] (#2884)
borichellow Apr 15, 2024
30e14ee
feat: display avs and CC version on all builds (#2894)
MohamadJaara Apr 16, 2024
0991c31
fix: secure switching to invalid account and disable composer [WPB-73…
saleniuk Apr 22, 2024
de8ade9
refactor: make learn more links clickable for automation [WPB-5888] (…
saleniuk Apr 22, 2024
2c071dd
feat(config): separate lower KeyPackage limit and set to false (WPB-8…
mchenani Apr 23, 2024
ac56dd3
fix: remove duplicated debug id in settings screen [WPB-8626] (#2926)
saleniuk Apr 24, 2024
413a82b
fix: Handle 1o1 conversations when no key packages [WPB-6936] (#2936)
borichellow Apr 25, 2024
8c1b254
fix(e2ei): set user display name correctly for the certificate downlo…
mchenani Apr 26, 2024
3b61110
fix: code style
mchenani Apr 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .github/workflows/cherry-pick-rc-to-develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ jobs:
cd ..
git add ${{ env.SUBMODULE_NAME }}
git commit -m "Update submodule ${{ env.SUBMODULE_NAME }} to latest from ${{ env.TARGET_BRANCH }}"
echo "lastCommitMessage=$LAST_COMMIT_MESSAGE" >> $GITHUB_ENV
# Base64 encode the commit message to avoid issues with newlines and special characters
echo "lastCommitMessageBase64=$(echo "$LAST_COMMIT_MESSAGE" | base64 -w 0 )" >> $GITHUB_ENV

- name: Get Cherry-pick commit
id: get-cherry
Expand All @@ -101,13 +102,23 @@ jobs:
if [[ -n "${{ env.SUBMODULE_NAME }}" ]]; then
# If SUBMODULE_NAME is set
git reset --soft HEAD~2
git commit -m "${{ env.lastCommitMessage }}"
# Decode the base64-encoded string
LAST_COMMIT_MESSAGE=$(echo "${{ env.lastCommitMessageBase64 }}" | base64 --decode)
git commit -m "$LAST_COMMIT_MESSAGE"
fi

# Get the SHA of the current commit (either squashed or not based on the condition above)
CHERRY_PICK_COMMIT=$(git rev-parse HEAD)
echo "cherryPickCommit=$CHERRY_PICK_COMMIT" >> $GITHUB_ENV

- name: Get Original Author
id: get-author
if: env.shouldCherryPick == 'true'
run: |
ORIGINAL_AUTHOR=$(git log -1 --pretty=format:'%an <%ae>' ${{ github.event.pull_request.merge_commit_sha }})
echo "Original author: $ORIGINAL_AUTHOR"
echo "originalAuthor=$ORIGINAL_AUTHOR" >> $GITHUB_ENV

- name: Cherry-pick commits
id: commit-cherry-pick
if: env.shouldCherryPick == 'true'
Expand All @@ -122,7 +133,10 @@ jobs:
echo "Captured conflicted files: $CONFLICTED_FILES"
if [[ "$OUTPUT" == *"CONFLICT"* ]]; then
# Commit the remaining conflicts
git commit -am "Commit with unresolved merge conflicts outside of ${{ env.SUBMODULE_NAME }}"
git add .
git commit --author "${{ env.originalAuthor }}" -am "Commit with unresolved merge conflicts outside of ${{ env.SUBMODULE_NAME }}"
else
git commit --author "${{ env.originalAuthor }}" --amend --no-edit
fi

# Push branch and remove temp
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/gradle-run-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,19 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: report
path: app/build/reports/jacoco
path: app/build/reports/kover

- name: Download Test Reports Folder
uses: actions/download-artifact@v4
with:
name: report
path: app/build/reports/jacoco
path: app/build/reports/kover
merge-multiple: true

- name: Upload Test Report
uses: codecov/codecov-action@v3
with:
files: "app/build/reports/jacoco/jacocoReport/jacocoReport.xml"
files: "app/build/reports/kover/report.xml"

- name: Cleanup Gradle Cache
# Remove some files from the Gradle cache, so they aren't cached by GitHub Actions.
Expand Down
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,9 @@ lint/tmp/

# Autogenerated file with git hash information.
app/src/main/assets/version.txt
app/src/main/assets/dependencies_version.json
/intellij.gdsl

# Editor temporary files
*~
\#*#
3 changes: 1 addition & 2 deletions AR-builder.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ pipeline {
string(name: 'SOURCE_BRANCH', description: 'Branch or PR name to')
string(name: 'CHANGE_BRANCH', description: 'Change branch name to build only used to checkout the correct branch if you need the branch name use SOURCE_BRANCH')
choice(name: 'BUILD_TYPE', choices: ['Compatrelease', 'Debug', 'Release', 'Compat'], description: 'Build Type for the Client')
choice(name: 'FLAVOR', choices: ['Prod', 'Dev', 'Staging', 'Internal', 'Beta'], description: 'Product Flavor to build')
choice(name: 'FLAVOR', choices: ['Prod', 'Fdroid', 'Dev', 'Staging', 'Internal', 'Beta'], description: 'Product Flavor to build')
booleanParam(name: 'UPLOAD_TO_S3', defaultValue: false, description: 'Boolean Flag to define if the build should be uploaded to S3')
booleanParam(name: 'UPLOAD_TO_PLAYSTORE_ENABLED', defaultValue: false, description: 'Boolean Flag to define if the build should be uploaded to Playstore')
booleanParam(name: 'RUN_UNIT_TEST', defaultValue: true, description: 'Boolean Flag to define if the unit tests should be run')
Expand Down Expand Up @@ -540,7 +540,6 @@ pipeline {
}
}

sh './gradlew jacocoReport'
wireSend(secret: env.WIRE_BOT_SECRET, message: "**[#${BUILD_NUMBER} Link](${BUILD_URL})** [${SOURCE_BRANCH}] - ✅ SUCCESS 🎉" + "\nLast 5 commits:\n```text\n$lastCommits\n```")
}

Expand Down
2 changes: 1 addition & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ List<String> defineFlavor() {
} else if (branchName == "develop") {
return ['Staging', 'Dev']
} else if (branchName == "prod") {
return ['Prod']
return ['Prod', 'Fdroid']
} else if (branchName == "internal") {
return ['Internal']
}
Expand Down
42 changes: 39 additions & 3 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import scripts.Variants_gradle

/*
* Wire
* Copyright (C) 2024 Wire Swiss GmbH
Expand Down Expand Up @@ -42,6 +44,11 @@ repositories {
google()
}

fun isFossSourceSet(): Boolean {
return (Variants_gradle.Default.explicitBuildFlavor() ?: gradle.startParameter.taskRequests.toString())
.lowercase()
.contains("fdroid")
}
android {
// Most of the configuration is done in the build-logic
// through the Wire Application convention plugin
Expand All @@ -56,8 +63,30 @@ android {
jniLibs.pickFirsts.add("**/libsodium.so")
}
android.buildFeatures.buildConfig = true

val fdroidBuild = isFossSourceSet()

sourceSets {
// Add the "foss" sourceSets for the fdroid flavor
if (fdroidBuild) {
getByName("fdroid") {
java.srcDirs("src/foss/kotlin", "src/prod/kotlin")
res.srcDirs("src/prod/res")
println("Building with FOSS sourceSets")
}
// For all other flavors use the "nonfree" sourceSets
} else {
getByName("main") {
java.srcDirs("src/nonfree/kotlin")
println("Building with non-free sourceSets")
}
}
}
}




dependencies {
implementation("com.wire.kalium:kalium-logic")
implementation("com.wire.kalium:kalium-util")
Expand All @@ -70,6 +99,7 @@ dependencies {
implementation(libs.androidx.splashscreen)
implementation(libs.androidx.exifInterface)
implementation(libs.androidx.biometric)
implementation(libs.androidx.startup)

implementation(libs.ktx.dateTime)
implementation(libs.material)
Expand Down Expand Up @@ -140,10 +170,16 @@ dependencies {
implementation(libs.bundlizer.core)

// firebase
implementation(platform(libs.firebase.bom))
implementation(libs.firebase.fcm)
var fdroidBuild = isFossSourceSet()

if (!fdroidBuild) {
implementation(platform(libs.firebase.bom))
implementation(libs.firebase.fcm)
implementation(libs.googleGms.location)
} else {
println("Excluding FireBase for FDroid build")
}
implementation(libs.androidx.work)
implementation(libs.googleGms.location)

// commonMark
implementation(libs.commonmark.core)
Expand Down
Loading
Loading