-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2ei): set user display name correctly for the certificate downloaded file (WPB-8606) #2941
Conversation
Co-authored-by: Yamil Medina <[email protected]>
Co-authored-by: AndroidBob <[email protected]>
Co-authored-by: yamilmedina <[email protected]>
…-6145) - cherrypick (#2635)
…2642) Co-authored-by: Yamil Medina <[email protected]>
Co-authored-by: Yamil Medina <[email protected]>
…rsation (WPB-5834) (#2659)
Co-authored-by: Oussama Hassine <[email protected]>
…rash [WPB-4716] (#2661)
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
…ce only dependencies or not (#2890)
Co-authored-by: Mojtaba Chenani <[email protected]>
Test Results820 tests 820 ✅ 7m 55s ⏱️ Results for commit 3b61110. ♻️ This comment has been updated with latest results. |
Build 4477 failed. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4478 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion about making it simpler to use
val certificateString: String, | ||
val isSelfUser: Boolean, | ||
val otherUserName: String? = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- we should keep using the handle instead of the name, since the handle is unique.
- to simplify the screen, we can only pass the user ID and fetch the handle from DB when needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feature is fancy and no requirements on it, and display name on the file might be more readable, didn't want to do a query to fetch data that is unnecessary, also since we add a date to the end of the file, duplicate names won't occur.
5638df4
to
70f61a5
Compare
…aded file
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Set display name for the certificate downloaded file.
Issues
The self user name was set even for other users cert.
Causes (Optional)
Wasn't handled.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.