Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show incoming call screen for second account #2929

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Apr 23, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After calling refactor #2882, the app is no longer showing incoming call screen for second account

Causes (Optional)

We are not switching account when we open incoming call screen of second account.

Solutions

Try to switch account if needed when showing incoming call screen

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, borichellow, MohamadJaara, vitorhugods and saleniuk and removed request for a team April 23, 2024 08:46
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 44.11%. Comparing base (e0d9134) to head (aeb1570).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2929      +/-   ##
===========================================
+ Coverage    43.81%   44.11%   +0.30%     
===========================================
  Files          443      443              
  Lines        14302    14311       +9     
  Branches      2456     2461       +5     
===========================================
+ Hits          6266     6314      +48     
+ Misses        7355     7306      -49     
- Partials       681      691      +10     
Files Coverage Δ
...n/com/wire/android/feature/AccountSwitchUseCase.kt 61.64% <100.00%> (ø)
...kotlin/com/wire/android/ui/calling/CallActivity.kt 0.00% <ø> (ø)
...m/wire/android/ui/calling/CallActivityViewModel.kt 95.23% <87.50%> (-4.77%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d9134...aeb1570. Read the comment docs.

Copy link
Contributor

github-actions bot commented Apr 23, 2024

Test Results

906 tests  +3   906 ✅ +3   14m 34s ⏱️ + 3m 37s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit aeb1570. ± Comparison against base commit e0d9134.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4388 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4416 succeeded.

The build produced the following APK's:

@ohassine ohassine enabled auto-merge April 25, 2024 08:36
@ohassine ohassine added this pull request to the merge queue Apr 25, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2024
@AndroidBob
Copy link
Collaborator

Build 4442 succeeded.

The build produced the following APK's:

@ohassine ohassine enabled auto-merge April 25, 2024 10:11
@ohassine ohassine added this pull request to the merge queue Apr 25, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4451 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit ecb1140 Apr 25, 2024
12 checks passed
@ohassine ohassine deleted the switch-account-on-receiving-call-on-second-account branch April 25, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants