Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incoming call screen is not shown on second account #2956

Merged
merged 4 commits into from
May 2, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented May 2, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issue

The app does not show incoming call screen for the second account.

Cause

Some changes from this PR #2929 were removed after resolving conflicts of this PR #2912

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, yamilmedina, alexandreferris, borichellow, vitorhugods and mchenani and removed request for a team May 2, 2024 12:47
@ohassine ohassine changed the base branch from develop to release/candidate May 2, 2024 13:03
@pull-request-size pull-request-size bot added size/M and removed size/XS labels May 2, 2024
@ohassine ohassine changed the base branch from release/candidate to develop May 2, 2024 13:03
@pull-request-size pull-request-size bot added size/XS and removed size/M labels May 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 44.19%. Comparing base (b1b3f71) to head (5b09b0a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2956      +/-   ##
===========================================
+ Coverage    44.08%   44.19%   +0.11%     
===========================================
  Files          444      444              
  Lines        14454    14456       +2     
  Branches      2474     2475       +1     
===========================================
+ Hits          6372     6389      +17     
+ Misses        7395     7374      -21     
- Partials       687      693       +6     
Files Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
...in/com/wire/android/notification/PendingIntents.kt 0.00% <0.00%> (ø)
...kotlin/com/wire/android/ui/calling/CallActivity.kt 0.00% <0.00%> (ø)
...m/wire/android/notification/NotificationActions.kt 0.00% <0.00%> (ø)
...re/android/notification/CallNotificationManager.kt 38.05% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b3f71...5b09b0a. Read the comment docs.

Copy link
Contributor

github-actions bot commented May 2, 2024

Test Results

924 tests  ±0   924 ✅ ±0   16m 50s ⏱️ + 7m 7s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit 5b09b0a. ± Comparison against base commit b1b3f71.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

…all-on-second-account

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/calling/CallActivity.kt
@ohassine ohassine enabled auto-merge May 2, 2024 14:22
@ohassine ohassine added this pull request to the merge queue May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2024
@ohassine ohassine enabled auto-merge May 2, 2024 15:11
@ohassine ohassine added this pull request to the merge queue May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 68a7371 May 2, 2024
11 of 12 checks passed
@ohassine ohassine deleted the fix-not-receving-call-on-second-account branch May 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants