Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update compose to version 1.5 #2248

Merged
merged 7 commits into from
Sep 21, 2023
Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 20, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

This PR aims to upgrade to compose 1.5
Upgrading to that version requires usage of API 34

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, alexandreferris, borichellow, vitorhugods, trOnk12 and saleniuk and removed request for a team September 20, 2023 07:46
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Test Results

611 tests  ±0   610 ✔️ ±0   6m 18s ⏱️ + 2m 9s
  88 suites ±0       1 💤 ±0 
  88 files   ±0       0 ±0 

Results for commit c77ffa1. ± Comparison against base commit 1277cd7.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 853 failed.

@AndroidBob
Copy link
Collaborator

Build 858 failed.

@AndroidBob
Copy link
Collaborator

Build 868 failed.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2248 (c77ffa1) into develop (1277cd7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2248      +/-   ##
=============================================
- Coverage      40.38%   40.37%   -0.01%     
  Complexity      1007     1007              
=============================================
  Files            318      318              
  Lines          11617    11619       +2     
  Branches        1539     1539              
=============================================
  Hits            4691     4691              
- Misses          6487     6489       +2     
  Partials         439      439              
Files Changed Coverage Δ
...tlin/com/wire/android/ui/debug/DebugDataOptions.kt 0.00% <0.00%> (ø)
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1277cd7...c77ffa1. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 869 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Sep 21, 2023
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit d68c9ca Sep 21, 2023
11 checks passed
@ohassine ohassine deleted the update_to_compose_1.5 branch September 21, 2023 11:39
@AndroidBob
Copy link
Collaborator

Build 884 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants