Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to API 34 #2073

Merged
merged 3 commits into from
Sep 21, 2023
Merged

chore: upgrade to API 34 #2073

merged 3 commits into from
Sep 21, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 20, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Upgrade target API to 34.
Needed to use compose 1.5.1 #2248

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Unit Test Results

   415 files   -   22     415 suites   - 22   29s ⏱️ - 2m 30s
2 270 tests  - 103  2 150 ✔️  - 120  120 💤 +17  0 ±0 

Results for commit eca01b0. ± Comparison against base commit 58639ea.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 20, 2023

Datadog Report

All test runs c7779d9 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2150 120 10m 27.1s Link
kalium-jvm 0 0 0 2270 103 9m 53s Link

@MohamadJaara MohamadJaara added this pull request to the merge queue Sep 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2023
@alexandreferris alexandreferris added this pull request to the merge queue Sep 20, 2023
@ohassine ohassine removed this pull request from the merge queue due to a manual request Sep 20, 2023
@ohassine ohassine added this pull request to the merge queue Sep 21, 2023
Merged via the queue into develop with commit 9ca6b83 Sep 21, 2023
15 checks passed
@ohassine ohassine deleted the upgrade_to_api_34 branch September 21, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants