Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mention highlight [WPB-3507] #2164

Merged
merged 4 commits into from
Sep 4, 2023
Merged

fix: mention highlight [WPB-3507] #2164

merged 4 commits into from
Sep 4, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Sep 1, 2023 •
edited by alexandreferris
Loading

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • fixed highlighting user name and handle
  • fixed crash when adding style with higher index than text length

@Garzas Garzas self-assigned this Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023 •
edited
Loading

Test Results

556 tests   555 ✔️  25s ⏱️
  78 suites      1 💤
  78 files        0 ❌

Results for commit 5a18b00.

♻️ This comment has been updated with latest results.

@Garzas Garzas mentioned this pull request Sep 1, 2023
Merged
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Merged
4 tasks
@AndroidBob
Copy link
Collaborator

Build 472 succeeded.

The build produced the following APK's:

@Garzas Garzas merged commit 4fb4f46 into release/cycle-4.3 Sep 4, 2023
11 checks passed
@Garzas Garzas deleted the fix/cycle-4-3-mention-highlight branch September 4, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@tmspzz tmspzz tmspzz approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@borichellow borichellow Awaiting requested review from borichellow

@ohassine ohassine Awaiting requested review from ohassine

Assignees

@Garzas Garzas

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @AndroidBob @tmspzz @alexandreferris