Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mention highlight [WPB-3507] #2165

Merged
merged 5 commits into from
Sep 1, 2023
Merged

fix: mention highlight [WPB-3507] #2165

merged 5 commits into from
Sep 1, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Sep 1, 2023

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Cherry pick from #2164

@Garzas Garzas requested review from yamilmedina, ohassine and a team September 1, 2023 12:17
@Garzas Garzas self-assigned this Sep 1, 2023
@Garzas Garzas requested review from alexandreferris, borichellow and MohamadJaara and removed request for a team September 1, 2023 12:17
@Garzas Garzas changed the title Fix/mention highlight fix: mention highlight [WPB-3507] Sep 1, 2023
@tmspzz tmspzz enabled auto-merge (squash) September 1, 2023 12:28
@tmspzz tmspzz merged commit 96d1879 into release/candidate Sep 1, 2023
7 checks passed
@tmspzz tmspzz deleted the fix/mention-highlight branch September 1, 2023 12:37
github-actions bot pushed a commit that referenced this pull request Sep 1, 2023
@Garzas @github-actions
fix: mention highlight [WPB-3507] (#2165)
e8bbba0
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Merged
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 474 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@tmspzz tmspzz tmspzz approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@ohassine ohassine Awaiting requested review from ohassine

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

Assignees

@Garzas Garzas

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @AndroidBob @tmspzz @alexandreferris