fix: show proper empty screen when no contacts [WPB-250] #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saleniuk
requested review from
a team,
yamilmedina,
MohamadJaara,
mchenani,
Garzas and
ohassine
and removed request for
a team
alexandreferris
approved these changes
Aug 28, 2023
|
APKs built during tests are available here. Scroll down to Artifacts! |
MohamadJaara
approved these changes
Aug 28, 2023
yamilmedina
approved these changes
Aug 29, 2023
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 426 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 442 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 484 succeeded. The build produced the following APK's: |
|
Build 498 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2023
Co-authored-by: Oussama Hassine <[email protected]> Co-authored-by: Yamil Medina <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When user does not have any contacts, he/she sees an empty screen when creating new conversation and can easily get confused because of that.
Solutions
Add proper empty screen according to the design documentation and fix returning
EmptyResultwhen there are no contacts.Testing
Test Coverage (Optional)
How to Test
Log in to a personal account which does not yet have any contacts.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.