Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show proper empty screen when no contacts [WPB-250] #2175

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 4, 2023

StoryWPB-250 Implement empty state for contact list

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When user does not have any contacts, he/she sees an empty screen when creating new conversation and can easily get confused because of that.

Solutions

Add proper empty screen according to the design documentation and fix returning EmptyResult when there are no contacts.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Log in to a personal account which does not yet have any contacts.

Attachments (Optional)

Before After   
empty_contacts_list_before empty_contacts_list_after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2175 (7c8b64c) into develop (780f878) will increase coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2175      +/-   ##
=============================================
+ Coverage      40.95%   40.97%   +0.01%     
- Complexity       994      995       +1     
=============================================
  Files            310      310              
  Lines          11386    11386              
  Branches        1518     1518              
=============================================
+ Hits            4663     4665       +2     
+ Misses          6283     6281       -2     
  Partials         440      440              
Files Changed Coverage Δ
...home/conversations/search/SearchPeopleViewModel.kt 69.56% <ø> (+0.86%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780f878...7c8b64c. Read the comment docs.

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 4, 2023

Test Results

599 tests  +3   598 ✔️ +3   4m 41s ⏱️ - 3m 13s
  85 suites ±0       1 💤 ±0 
  85 files   ±0       0 ±0 

Results for commit 7c8b64c. ± Comparison against base commit 780f878.

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 4, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 521 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team, yamilmedina, alexandreferris, borichellow, mchenani and ohassine and removed request for a team September 5, 2023 06:49
@ohassine ohassine added this pull request to the merge queue Sep 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2023
@ohassine ohassine added this pull request to the merge queue Sep 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2023
@ohassine ohassine added this pull request to the merge queue Sep 5, 2023
Merged via the queue into develop with commit e08cb53 Sep 5, 2023
11 checks passed
@ohassine ohassine deleted the fix/empty_contacts_list-cherry-pick branch September 5, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants