-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show proper empty screen when no contacts [WPB-250] #2175
Conversation
Co-authored-by: Oussama Hassine <[email protected]> Co-authored-by: Yamil Medina <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #2175 +/- ##
=============================================
+ Coverage 40.95% 40.97% +0.01%
- Complexity 994 995 +1
=============================================
Files 310 310
Lines 11386 11386
Branches 1518 1518
=============================================
+ Hits 4663 4665 +2
+ Misses 6283 6281 -2
Partials 440 440
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 521 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When user does not have any contacts, he/she sees an empty screen when creating new conversation and can easily get confused because of that.
Solutions
Add proper empty screen according to the design documentation and fix returning
EmptyResult
when there are no contacts.Testing
Test Coverage (Optional)
How to Test
Log in to a personal account which does not yet have any contacts.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.