feat: handle conversation access update event (WPB-10850) #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alexandreferris
requested review from
a team,
typfel,
yamilmedina,
MohamadJaara,
mchenani,
saleniuk,
Garzas and
vitorhugods
and removed request for
a team
Datadog ReportBranch report: ✅ 0 Failed, 3088 Passed, 105 Skipped, 12.16s Total Time |
yamilmedina
approved these changes
Aug 30, 2024
MohamadJaara
approved these changes
Aug 30, 2024
alexandreferris
deleted the
feat/handle_conversation_access_update_event
branch
github-actions bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
* feat: add mappers from api to model and from model to dao for access update event * feat: add correct receiving values for access update (access and accessRole) * feat: create handler for access update event received and its usage * feat: add return of Either for access update handler * feat: rename handler to remove redundant conversation * feat: rename clashing function naming * test: add tests for receiving access update event * chore: rename mapper method naming * test: add test for new mappings in ConversationMapper * chore: renaming of access update event handler * test: add tests for AccessUpdateHandler
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
) * feat: add mappers from api to model and from model to dao for access update event * feat: add correct receiving values for access update (access and accessRole) * feat: create handler for access update event received and its usage * feat: add return of Either for access update handler * feat: rename handler to remove redundant conversation * feat: rename clashing function naming * test: add tests for receiving access update event * chore: rename mapper method naming * test: add test for new mappings in ConversationMapper * chore: renaming of access update event handler * test: add tests for AccessUpdateHandler Co-authored-by: Alexandre Ferris <[email protected]>
echoes-hq
bot
added
the
echoes: bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When receiving
conversation.access-updatewe were not handling properly from syncCauses (Optional)
Not implemented
Solutions
Add
AccessUpdateEventHandlerto handle events forconversation.access-updateand properly update conversation access rolesTesting
Test Coverage (Optional)
How to Test