-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle conversation access update event (WPB-10850) 🍒 #2982
feat: handle conversation access update event (WPB-10850) 🍒 #2982
Conversation
* feat: add mappers from api to model and from model to dao for access update event * feat: add correct receiving values for access update (access and accessRole) * feat: create handler for access update event received and its usage * feat: add return of Either for access update handler * feat: rename handler to remove redundant conversation * feat: rename clashing function naming * test: add tests for receiving access update event * chore: rename mapper method naming * test: add test for new mappings in ConversationMapper * chore: renaming of access update event handler * test: add tests for AccessUpdateHandler
Quality Gate passedIssues Measures |
Test Results3 193 tests +6 3 088 ✔️ +6 3m 54s ⏱️ +18s Results for commit 2eee6dc. ± Comparison against base commit 1549f4c. This pull request removes 1 and adds 7 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2982 +/- ##
===========================================
+ Coverage 52.50% 52.52% +0.02%
===========================================
Files 1295 1296 +1
Lines 49779 49816 +37
Branches 4642 4644 +2
===========================================
+ Hits 26137 26167 +30
- Misses 21767 21775 +8
+ Partials 1875 1874 -1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3088 Passed, 105 Skipped, 12.54s Total Time |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When receiving
conversation.access-update
we were not handling properly from syncCauses (Optional)
Not implemented
Solutions
Add
AccessUpdateEventHandler
to handle events forconversation.access-update
and properly update conversation access rolesTesting
Test Coverage (Optional)
How to Test