Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to java 17 #1902

Merged
merged 9 commits into from
Jul 24, 2023
Merged

chore: update to java 17 #1902

merged 9 commits into from
Jul 24, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jul 20, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Updated project to java 17

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

Unit Test Results

   387 files   - 20     387 suites   - 20   22s ⏱️ - 1m 31s
2 104 tests  - 96  1 982 ✔️  - 120  122 💤 +24  0 ±0 

Results for commit 7149e2c. ± Comparison against base commit 143a07a.

♻️ This comment has been updated with latest results.

@vitorhugods
Copy link
Member

I've raised a PR on cryptobox to upgrade the JDK used on the Docker images, and also build it using JDK 17.

We will need to bump the docker image to 1.4.0 to get it, once it's merged and published.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #1902 (7149e2c) into release/candidate (143a07a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##             release/candidate    #1902      +/-   ##
=======================================================
- Coverage                56.07%   56.06%   -0.01%     
  Complexity                  35       35              
=======================================================
  Files                      987      987              
  Lines                    36873    36863      -10     
  Branches                  3315     3315              
=======================================================
- Hits                     20677    20668       -9     
  Misses                   14814    14814              
+ Partials                  1382     1381       -1     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 143a07a...7149e2c. Read the comment docs.

@Garzas Garzas changed the base branch from develop to release/candidate July 24, 2023 13:38
@Garzas Garzas merged commit d42a5fd into release/candidate Jul 24, 2023
9 checks passed
@Garzas Garzas deleted the chore/update-java-17 branch July 24, 2023 14:03
github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
* chore: update to java 17

* ci: bump cryptobox image to 1.4.0

* updated kotlin to jvm 17

---------

Co-authored-by: Vitor Hugo Schwaab <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 24, 2023
4 tasks
vitorhugods added a commit that referenced this pull request Jul 24, 2023
Co-authored-by: Jakub Żerko <[email protected]>
Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants