Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to java 17 #1915

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Updated project to java 17

* chore: update to java 17

* ci: bump cryptobox image to 1.4.0

* updated kotlin to jvm 17

---------

Co-authored-by: Vitor Hugo Schwaab <[email protected]>
@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Jul 24, 2023
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨🏻‍🍳🤌🏻

@github-actions
Copy link
Contributor Author

github-actions bot commented Jul 24, 2023

Unit Test Results

   407 files  ±0     407 suites  ±0   2m 42s ⏱️ +12s
2 200 tests ±0  2 102 ✔️ ±0  98 💤 ±0  0 ±0 

Results for commit 6ce5d0f. ± Comparison against base commit 7e7615f.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Merging #1915 (6ce5d0f) into develop (143a07a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #1915      +/-   ##
=============================================
- Coverage      56.07%   56.06%   -0.02%     
  Complexity        35       35              
=============================================
  Files            987      986       -1     
  Lines          36873    36855      -18     
  Branches        3315     3314       -1     
=============================================
- Hits           20677    20661      -16     
+ Misses         14814    14812       -2     
  Partials        1382     1382              
Impacted Files Coverage Δ
.../base/authenticated/message/EnvelopeProtoMapper.kt 100.00% <100.00%> (ø)
...base/authenticated/message/OtrClientEntryMapper.kt 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e7615f...6ce5d0f. Read the comment docs.

@vitorhugods vitorhugods merged commit 3f79b42 into develop Jul 24, 2023
9 checks passed
@vitorhugods vitorhugods deleted the chore/update-java-17-cherry-pick branch July 24, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch 👕 size: S type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants