Override serverUrl in wasp deploy fly deploy command

[Case-E]

Description

Fixes #2233

Select what type of change this PR introduces:

1. Just code/docs improvement (no functional change).
2. Bug fix (non-breaking change which fixes an issue).
3. New feature (non-breaking change which adds functionality).
4. Breaking change (fix or feature that would cause existing functionality to not work as expected).

Update Waspc ChangeLog and version if needed

If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following:

1. I updated ChangeLog.md with description of the change this PR introduces.
2. I bumped waspc version in waspc.cabal to reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.

Update example apps if needed

If you did code changes and added a new feature or modified an existing feature, make sure you satisfy the following:

1. I updated waspc/examples/todoApp as needed (updated modified feature or added new feature) and manually checked it works correctly.
2. I updated waspc/headless-test/examples/todoApp and its e2e tests as needed (updated modified feature and its tests or added new feature and new tests for it).

WORKAROUND for anyone who needs this before it is merged

0. Make sure that you have flyctl installed and logged in. You can run flyctl auth whoami
1. Run these commands from the root of your project

wasp build

2. Navigate to the build folder

cd .wasp/build/web-app

3. Copy the client config file into the build dir

cp ../../../fly-client.toml ./fly.toml

4. Install dependencies and build the client

npm install && REACT_APP_API_URL=https://sub.domain.com npm run build

5. Create the Dockerfile and add the following contents

touch Dockerfile

FROM pierrezemb/gostatic
CMD [ "-fallback", "index.html" ]
COPY ./build/ /srv/http/

6. Create the docker ignore file

touch .dockerignore

7. Deploy with this command. (optional: you can pass --local-only in place of --remote-only to build locally)

flyctl deploy --remote-only

[Case-E]

The tests were failing even without the changes, so not introduced by the changes in this PR.

[Case-E]

It looks like I am unable to test this locally. Not sure why the deploy command seems to be throwing this error:

wasp-cli: npm: readCreateProcessWithExitCode: chdir: invalid argument (Bad file descriptor)

Other wasp-cli commands seem to be working. Tested build and start

[Case-E]

Everything works as expected ]. will bump the version and update the changelog.

[infomiho]

Hey @Case-E, thank you for the contribution.

We'll need to do a few things before we can merge this:

• You'll need to sync your fork to make sure it includes the latest code
• You'll need to merge main into your branch
• I'll need to review the code changes and test it out locally
• You'll need to make sure the CI is passing (probably syncing the fork will do the trick)

[infomiho]

Tested it locally, works as expected.

Left some minor comments.

[Case-E]

Thanks @infomiho I didn't realise there were more changes pushed upstream from when I branched out.

I've made the changes. As this needs to go into the current release, do I need to update the version (patch) or would y'all be batching multiple fixes into a single patch? Also should I add to the changelog?

[Case-E]

Looks like the CI failed to cancel out existing running jobs, y'all may want to check why or add it to your tech debt.
https://github.com/wasp-lang/wasp/actions/runs/10456113609/job/28952663383?pr=2234

[Case-E]

Added a workaround to the description in case anyone needs it before the changes are merged.

[infomiho]

@Case-E sorry for taking so long to get back to you, thank you for your hard work on this.

I realised now that we can remove the use of stripTrailingSlash since the client does that before it uses the env var: https://github.com/wasp-lang/wasp/blob/main/waspc/data/Generator/templates/sdk/wasp/client/config.ts#L4

So, remove that helper and the use of it and we'll merge it! I'll update the Changelog with this change later.

[Case-E]

@infomiho No sorry needed at all! I didn't venture into the client code, so that all makes sense. I've removed the helper now.

[Case-E]

When you get a chance, could you also do an initial review of the deploy action — wasp-lang/deploy-action#2? I haven't tested that yet though, will do it after this change is merged and released.