Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to define custom server url #2

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

Case-E
Copy link
Contributor

@Case-E Case-E commented Aug 12, 2024

fixes #1

Can only be merged after wasp-lang/wasp#2234

@Case-E Case-E changed the title updated checkout to v4 and added ability to define server-url Add ability to define custom server url Aug 12, 2024
@hellwaiver
Copy link

Is this working?

@Case-E
Copy link
Contributor Author

Case-E commented Sep 17, 2024

@hellwaiver You should be able to use the workaround I have here: wasp-lang/wasp#2234

Those changes are merged but pending a release. Once the changes are released on Wasp, this MR can be merged.

@Case-E
Copy link
Contributor Author

Case-E commented Sep 17, 2024

Tagging @Martinsos @infomiho to see if they have any insights here.

@infomiho
Copy link
Collaborator

@Case-E This looks good to me 👍 let's merge it after the 0.15.0 release, as you said :)

@Case-E
Copy link
Contributor Author

Case-E commented Oct 14, 2024

@infomiho Now that 0.15.0 is released, can we test and merge this?

@infomiho
Copy link
Collaborator

@Case-E sorry for dropping the ball on this! I think this is ready to be merged.

@infomiho infomiho merged commit 33d4393 into wasp-lang:main Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle deploying with a custom server URL
3 participants