Invoke refactoring #564
Draft
Invoke refactoring #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## optimize_call_result_push #564 +/- ##
==========================================================
Coverage 99.27% 99.28%
==========================================================
Files 86 86
Lines 13219 13218 -1
==========================================================
Hits 13123 13123
+ Misses 96 95 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
invoke_optimization
branch
from
0a1b432
to
30965cc
Compare
axic
force-pushed
the
invoke_optimization
branch
from
30965cc
to
6081ced
Compare
|
Rebased on top of #602. Can be benchmarked too. |
axic
force-pushed
the
optimize_call_result_push
branch
3 times, most recently
from
c7d1c71
to
62311e8
Compare
chfast
force-pushed
the
optimize_call_result_push
branch
2 times, most recently
from
7dd0274
to
90bd063
Compare
axic
force-pushed
the
invoke_optimization
branch
2 times, most recently
from
8aeb38f
to
aef6502
Compare
|
Rebased. If we want to keep the assertion from #602, then need the last commit, which likely negates all the benefits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #602.