Optimize call result push to the stack

wasmx · May 23, 2022 · 7dd0274 · 7dd0274
1 parent 9ae449c
commit 7dd0274
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/lib/fizzy/execute.cpp b/lib/fizzy/execute.cpp
@@ -524,12 +524,10 @@ inline bool invoke_function(const FuncType& func_type, uint32_t func_idx, Instan
 
     stack.drop(num_args);
 
-    const auto num_outputs = func_type.outputs.size();
-    // NOTE: we can assume these two from validation
-    assert(num_outputs <= 1);
-    assert(ret.has_value == (num_outputs == 1));
+    // NOTE: validation ensures there is at most 1 output value
+    assert(func_type.outputs.size() == (ret.has_value ? 1 : 0));
     // Push back the result
-    if (num_outputs != 0)
+    if (ret.has_value)
         stack.push(ret.value);
 
     return true;