-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support standard streamid syntax with unit tests #43
base: master
Are you sure you want to change the base?
Conversation
Not really a bug but could confuse others later.
Basic unit tests in place
@iSchluff I'm working on unit tests for this and noticed that the TestServerImpl_GetStatistics test fails. The tl;dr is that it's old vs new format. I can either update the test to use the SRT defined spec or figure out a way to base the answer on what was sent to the server in the first place. Thoughts? For now I've just reverted the output to the pre-change version just so the behavior doesn't change on dependent apps.
|
I'm not super attached to the url returned in GetStatistics. The main goal is having something that ffmpeg understands. So if the new format still works with ffplay I am fine with changing the result. |
@iSchluff Thanks! I'll test it locally with ffmpeg to double check and report back. |
ffplay works fine with the new url format |
Using new format for get stats
@iSchluff Any chance on a PR review? |
@iSchluff Any word on a review? Plz? ;) |
Quick heads-up: I have rebased your branch on top of our ongoing work to update the ecosystem. Unfortunately, the changes you are proposing are above my skill level wrt the SRT format. @iSchluff seems busy at the moment, please be patient. |
@danimo Ah cool, thanks for the update :) |
An updated version of #39 with unit tests. Also added support for passing on the
username
to the upstream AAA. Plus a few random non-bug fixes I ran across while I was at it.