Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support standard streamid syntax #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

calanor
Copy link

@calanor calanor commented Apr 17, 2024

Support the streamid access control methods as defined in the SRT
https://github.com/Haivision/srt/blob/master/docs/features/access-control.md

#!::m=(request|publish),r=(stream-key),u=(user),s=(password)

Maintains compatible with current syntax.

@iSchluff
Copy link
Member

iSchluff commented Jun 11, 2024

Looks pretty good,
Can you please also add some parsing tests for the new streamid format?

@gpmidi
Copy link

gpmidi commented Nov 25, 2024

I'm working on unit tests for this and noticed that the TestServerImpl_GetStatistics test fails. The tl;dr is that it's old vs new format. I can either update the test to use the SRT defined spec or figure out a way to base the answer on what was sent to the server in the first place. Thoughts?

=== RUN   TestServerImpl_GetStatistics
    server_test.go:52: Invalid stream statistics: got {s1 srt://testserver.de:1337?streamid=#!::m=request,r=s1 2 2024-11-25 14:48:26.374969306 -0500 EST m=+0.000745398}, expected {s1 srt://testserver.de:1337?streamid=play/s1 2 2024-11-25 14:48:26.374969306 -0500 EST m=+0.000745398}
--- FAIL: TestServerImpl_GetStatistics (0.00s)

My working branch is here.

@gpmidi
Copy link

gpmidi commented Nov 26, 2024

@iSchluff I'd recommend we close this in favor of #43 at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ enhancement ] Supports SRT Access Control streamid with recomended format
3 participants