-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update restore logic to allow Resource Modifiers to use data from the status field #8121
base: main
Are you sure you want to change the base?
Update restore logic to allow Resource Modifiers to use data from the status field #8121
Conversation
… status field Signed-off-by: Baudouin Herlicq <[email protected]>
Signed-off-by: Baudouin Herlicq <[email protected]>
b8e9fb0
to
e90ddd4
Compare
Signed-off-by: Baudouin Herlicq <[email protected]>
Signed-off-by: Baudouin Herlicq <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8121 +/- ##
==========================================
- Coverage 59.03% 59.02% -0.02%
==========================================
Files 358 364 +6
Lines 30141 30272 +131
==========================================
+ Hits 17795 17868 +73
- Misses 10907 10958 +51
- Partials 1439 1446 +7 ☔ View full report in Codecov by Sentry. |
@@ -58,6 +58,11 @@ resourceModifierRules: | |||
- copy | |||
- test (covered below) | |||
|
|||
### Limitations of Resource Modifiers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move limitations section to the bottom of the docs?
} | ||
|
||
ctx.log.Infof("restore status includes excludes: %+v", ctx.resourceStatusIncludesExcludes) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the concern that @reasonerjt had in #8094 (comment) still holds.
Please pitch in others - CC: @sseago, if this could impact any RIA flows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise please signoff - @reasonerjt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anshulahuja98 I'm unaware of any RIA that currently modifies status -- if I'm remembering correctly, don't we currently strip the status field before RIAs are run? I think that's one of the reasons we added unmodified item (itemFromBackup
) to the RIA input, as it still has the full status available for plugins to reference.
Thank you for contributing to Velero!
Please add a summary of your change
This PR change slightly the restore logic to make it possible to use the
status
field in Restore Resource Modifiers.The status field is now trimmed after applying the resource modifiers, not before, allowing patches in resource modifiers to reference the
status
field.Does your change fix a particular issue?
Fixes #8094
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.