Remove dependency of generated client part 2 #7041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
6190_part_2
branch
2 times, most recently
from
84728e2 to
21730a4
Compare
blackpiglet
force-pushed
the
6190_part_2
branch
from
21730a4 to
fefcb66
Compare
Codecov Report
@@ Coverage Diff @@
## main #7041 +/- ##
========================================
Coverage 61.00% 61.01%
========================================
Files 252 255 +3
Lines 26898 27050 +152
========================================
+ Hits 16409 16504 +95
- Misses 9326 9364 +38
- Partials 1163 1182 +19
|
blackpiglet
force-pushed
the
6190_part_2
branch
4 times, most recently
from
995fae7 to
1b5449a
Compare
blackpiglet
force-pushed
the
6190_part_2
branch
3 times, most recently
from
5b8af66 to
2334709
Compare
3 tasks
blackpiglet
requested review from
sseago,
anshulahuja98,
shubham-pampattiwar,
Lyndon-Li and
qiuming-best
ywk253100
reviewed
Nov 3, 2023
ywk253100
reviewed
Nov 3, 2023
blackpiglet
force-pushed
the
6190_part_2
branch
2 times, most recently
from
bd7b124 to
1cc0ce7
Compare
Remove dependecy of generate client from pkg/cmd/cli/snapshotLocation. Remove the Velero generated informer from PVB and PVR. Remove dependency of generated client from pkg/podvolume directory. Replace generated codec with runtime codec. Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
6190_part_2
branch
from
1cc0ce7 to
a221a88
Compare
ywk253100
approved these changes
Nov 3, 2023
Lyndon-Li
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #6190
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.