Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency of generated client part 3 #7051

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Nov 2, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6190

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #7051 (56b5e98) into main (a221a88) will decrease coverage by 0.02%.
Report is 30 commits behind head on main.
The diff coverage is 62.20%.

@@            Coverage Diff             @@
##             main    #7051      +/-   ##
==========================================
- Coverage   61.01%   60.99%   -0.02%     
==========================================
  Files         255      255              
  Lines       27050    27041       -9     
==========================================
- Hits        16504    16495       -9     
- Misses       9364     9368       +4     
+ Partials     1182     1178       -4     
Files Coverage Δ
.../resourcemodifiers/resource_modifiers_validator.go 100.00% <100.00%> (ø)
pkg/client/factory.go 50.92% <ø> (+0.92%) ⬆️
pkg/exposer/csi_snapshot.go 90.88% <100.00%> (ø)
pkg/repository/config/aws.go 50.00% <50.00%> (ø)
pkg/restore/pod_volume_restore_action.go 77.29% <88.88%> (+0.24%) ⬆️
pkg/cmd/cli/restore/logs.go 39.47% <0.00%> (+1.97%) ⬆️
pkg/restore/restore.go 65.75% <50.00%> (ø)
pkg/cmd/server/server.go 21.68% <0.00%> (-0.16%) ⬇️
pkg/repository/provider/unified_repo.go 86.05% <25.00%> (ø)
internal/resourcemodifiers/json_merge_patch.go 55.00% <55.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 2, 2023
@blackpiglet blackpiglet changed the title 6190 part 3 Remove dependency of generated client part 3 Nov 3, 2023
@blackpiglet blackpiglet marked this pull request as ready for review November 3, 2023 09:52
@blackpiglet blackpiglet force-pushed the 6190_part_3 branch 2 times, most recently from c7cf612 to 5d70555 Compare November 6, 2023 02:10
Replace generated discovery client with client-go client.
Remove generated client from PVR action.
Remove generated client from pkg/cmd directory.
Delete velero generate client from client factory.

Signed-off-by: Xun Jiang <[email protected]>
@Lyndon-Li Lyndon-Li merged commit 11938f9 into vmware-tanzu:main Nov 6, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-changelog has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate how to remove the generated legacy client-go code.
3 participants