Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version, and change base image of markdownlint #182

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

lubronzhan
Copy link
Contributor

@lubronzhan lubronzhan commented Mar 13, 2024

What this PR does / why we need it:

  • Update node version to newer version to fix issue
  • change base image of markdownlint to not to pull from docker
  • Refactor integration test a little

Which issue(s) this PR fixes:

Fixes ##181

Describe testing done for PR:

Special notes for your reviewer:

Release note:


New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

Signed-off-by: Lubron Zhan <[email protected]>
@lubronzhan lubronzhan force-pushed the topic/lubron/fix-181 branch from 9f1ba0a to 12a35d3 Compare March 13, 2024 00:10
Signed-off-by: Lubron Zhan <[email protected]>
Signed-off-by: Lubron Zhan <[email protected]>
@lubronzhan lubronzhan force-pushed the topic/lubron/fix-181 branch from 351fda7 to b5ea637 Compare March 13, 2024 01:36
This reverts commit b5ea637.
@lubronzhan lubronzhan requested a review from flawedmatrix March 13, 2024 02:25
@lubronzhan lubronzhan merged commit a70caef into vmware-tanzu:main Mar 13, 2024
4 checks passed
lubronzhan added a commit to lubronzhan/load-balancer-operator-for-kubernetes that referenced this pull request May 1, 2024
Signed-off-by: Lubron Zhan <[email protected]>
lubronzhan added a commit that referenced this pull request May 2, 2024
…update GOPROXY for docker file (#182) (#234)

* Cherry pick #182

Signed-off-by: Lubron Zhan <[email protected]>

* Update GOPROXY for dockerfile

Signed-off-by: Lubron Zhan <[email protected]>

---------

Signed-off-by: Lubron Zhan <[email protected]>
christianang pushed a commit to christianang/load-balancer-operator-for-kubernetes that referenced this pull request May 8, 2024
…nzu#182)

* Update node version
* Improve integration test
* change base image of markdownlint to not to pull from docker

---------

Signed-off-by: Lubron Zhan <[email protected]>
christianang added a commit that referenced this pull request May 8, 2024
[release-1.11.0] Update node version, and change base image of markdownlint (#182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants