Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.10.0] Update node version, and change base image of markdownlint (#182) #234

Conversation

lubronzhan
Copy link
Contributor

@lubronzhan lubronzhan commented May 1, 2024

What this PR does / why we need it:
Cherry pick #182
Otherwise the markdownlint job will fail

Also updated dockerfile's GOPROXY

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Cherry pick #182

To fix issues inside markdownlint run

Special notes for your reviewer:

Release note:


New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

Signed-off-by: Lubron Zhan <[email protected]>
@lubronzhan lubronzhan changed the title [1.10.0]fix cluster upgrade ako role doesn't update issue (#159) [1.10.0] Update node version, and change base image of markdownlint (#182) May 1, 2024
@lubronzhan
Copy link
Contributor Author

I need to fix the golang version looks like. It was still using 1.17, now go mod download will fail

@sunjayBhatia
Copy link
Contributor

I need to fix the golang version looks like. It was still using 1.17, now go mod download will fail

I was able to get the build to succeed locally changing this line:

diff --git a/Dockerfile-for-github-ci b/Dockerfile-for-github-ci
index 79a143a..7739517 100644
--- a/Dockerfile-for-github-ci
+++ b/Dockerfile-for-github-ci
@@ -11,7 +11,7 @@ WORKDIR /workspace
 COPY go.mod go.mod
 COPY go.sum go.sum
 
-ENV GOPROXY=direct
+ENV GOPROXY=https://proxy.golang.org
 RUN go mod download
 
 # Copy the go source

@lubronzhan
Copy link
Contributor Author

Nice! Let me change that

@lubronzhan
Copy link
Contributor Author

https://github.com/inetaf/netaddr

The repo is archived, then github stop advertising that name? So the build is only available in the cache now?

@sunjayBhatia
Copy link
Contributor

https://github.com/inetaf/netaddr

The repo is archived, then github stop advertising that name? So the build is only available in the cache now?

yeah i think the vanity url/dns setup for the package inet.af/netaddr doesn't exist anymore so we have to go through the go proxy to get to the github repo etc.

@lubronzhan lubronzhan merged commit fa86382 into vmware-tanzu:release-1.10.0 May 2, 2024
4 checks passed
@lubronzhan lubronzhan deleted the topic/lubron/cherrypick-node-version-bump branch May 2, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants