Add missing tables to globally routed list in schema tracker only if they are not already present in a VSchema#17371

Merged

rohit-nayak-ps merged 27 commits intovitessio:mainfrom planetscale:rohit/global-routing-tables-not-in-vschema

Jan 7, 2025

+872-153

Commits on Jan 2, 2025

Add missing tables to globally routed list in schema tracker only if they are not already present in a VSchema
rohit-nayak-ps
committed
Address review comment: needed to reverse the bools passed because the variable name had changed from positive to negative intent ...
rohit-nayak-ps
committed
Fix incorrect logical check
rohit-nayak-ps
committed
Add new logic for adding unique tables from unsharded keyspaces without vschemas to the global routing. Create more comprehensive unit test.
rohit-nayak-ps
committed
Add vtgate flag to turn on/off the logic to mark unsharded tables with no vschema as global. Enhance e2e test to handle both flag states with and without vschema
rohit-nayak-ps
committed
Add vtgate flag to turn on/off the logic to mark unsharded tables with no vschema as global. Enhance e2e test to handle both flag states with and without vschema
rohit-nayak-ps
committed
Fix flags test
rohit-nayak-ps
committed
Refactor e2e test
rohit-nayak-ps
committed
Add global routing e2e to CI
rohit-nayak-ps
committed
Add Extended unit test case
rohit-nayak-ps
committed
Add more cases
rohit-nayak-ps
committed
Add more cases
rohit-nayak-ps
committed
More tets cases
rohit-nayak-ps
committed
Remove incorrect comments from unit tests. Delete log lines added for debugging
rohit-nayak-ps
committed
Address review comments
rohit-nayak-ps
committed
Refactor e2e as suggested
rohit-nayak-ps
committed
feat: use the existing keyspace struct instead of creating a new one

GuptaManan100
authored and
rohit-nayak-ps
committed
Address review comments
rohit-nayak-ps
committed
Remove flag
rohit-nayak-ps
committed
Recreate flag help
rohit-nayak-ps
committed
Fix failing tests
rohit-nayak-ps
committed
Fix help files which were previously incorrectly generated using an older version because of incorrect go version
rohit-nayak-ps
committed
Remove unnecessary setting of keyspace name as performance opt
rohit-nayak-ps
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing tables to globally routed list in schema tracker only if they are not already present in a VSchema#17371

Commits on Jan 2, 2025

Add missing tables to globally routed list in schema tracker only if they are not already present in a VSchema

Address review comment: needed to reverse the bools passed because the variable name had changed from positive to negative intent ...

Fix incorrect logical check

Add new logic for adding unique tables from unsharded keyspaces without vschemas to the global routing. Create more comprehensive unit test.

Add vtgate flag to turn on/off the logic to mark unsharded tables with no vschema as global. Enhance e2e test to handle both flag states with and without vschema

Add vtgate flag to turn on/off the logic to mark unsharded tables with no vschema as global. Enhance e2e test to handle both flag states with and without vschema

Fix flags test

Refactor e2e test

Add global routing e2e to CI

Add Extended unit test case

Add more cases

Add more cases

More tets cases

Remove incorrect comments from unit tests. Delete log lines added for debugging

Address review comments

Refactor e2e as suggested

feat: use the existing keyspace struct instead of creating a new one

Address review comments

Remove flag

Recreate flag help

Fix failing tests

Fix help files which were previously incorrectly generated using an older version because of incorrect go version

Remove unnecessary setting of keyspace name as performance opt

Commits on Jan 3, 2025

refactor: remove additional struct

WIP

Commits on Jan 4, 2025

Refactor e2e test

Commits on Jan 5, 2025

Self-review