-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental: Add missing tables to globally routed list in schema tracker only if they are not already present in a VSchema #17371
base: main
Are you sure you want to change the base?
Conversation
…they are not already present in a VSchema Signed-off-by: Rohit Nayak <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17371 +/- ##
==========================================
+ Coverage 67.48% 67.67% +0.18%
==========================================
Files 1577 1583 +6
Lines 253424 254357 +933
==========================================
+ Hits 171033 172132 +1099
+ Misses 82391 82225 -166 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nomenclature nit, otherwise looks good to me!
…e variable name had changed from positive to negative intent ... Signed-off-by: Rohit Nayak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with this approach arises when there are multiple unsharded keyspaces. This makes adding the table to global routing non-deterministic, failing to fully achieve the intended purpose of this PR.
Signed-off-by: Rohit Nayak <[email protected]>
You mean if there are tables of the same name in multiple unsharded keyspaces (and which are not in the VSchemas). We could collect all tables names which will be added like this (not in VSchema, but found by schema tracking) first and validate that there are no duplicates, marking ones with duplicates as ambiguous, while others get globally routed. |
Discussed with @harshit-gangal . His point is that:
Options here are:
I guess the question is what is |
…ut vschemas to the global routing. Create more comprehensive unit test. Signed-off-by: Rohit Nayak <[email protected]>
…h no vschema as global. Enhance e2e test to handle both flag states with and without vschema Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Description
Follows up on the idea in #16517 by not considering tables already present in the globally routable list of tables.
Related Issue(s)
#16516
Checklist
Deployment Notes