Add llvm 18 for osx to ci #889
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
========================================
Coverage 94.37% 94.37%
========================================
Files 50 50
Lines 8366 8686 +320
========================================
+ Hits 7895 8197 +302
- Misses 471 489 +18 |
vgvassilev
force-pushed
the
add-llvm-18-osx-ci
branch
from
cbf7812
to
8131de9
Compare
|
@mcbarton, what is the fate of this PR? |
|
@vgvassilev I'll take another look at this PR in the coming week (got sidetracked with the work on xeus-cpp). I just need to make the ci avoid the need for curling a binary from the llvm project Github page, and it should work. |
mcbarton
force-pushed
the
add-llvm-18-osx-ci
branch
from
f3bbf6d
to
c505290
Compare
|
@vgvassilev are you able to take a look at this, or have someone else who can finish it off? Clad is building and the tests are running with llvm 18. I'm just a little too busy at the moment to work out why they some of them are failing and fix them (I also don't know which are the ones which are expected to fail). |
vgvassilev
force-pushed
the
add-llvm-18-osx-ci
branch
from
c505290
to
5d4fd66
Compare
vgvassilev
force-pushed
the
add-llvm-18-osx-ci
branch
from
5d4fd66
to
ea2e931
Compare
|
Looks like there is a single failure that might be hard to debug. Perhaps we should add a debug build based on clang-18 so that we can debug such issues on the bots. |
vgvassilev
force-pushed
the
add-llvm-18-osx-ci
branch
2 times, most recently
from
82f91c4
to
ba194a0
Compare
mcbarton
force-pushed
the
add-llvm-18-osx-ci
branch
from
ba194a0
to
b06b239
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -135,6 +135,11 @@ CUDA_HOST_DEVICE inline void __builtin_powf_pullback(float x, float exponent, | |||
| *d_exponent += t.pushforward * d_y; | |||
| } | |||
|
|
|||
| CUDA_HOST_DEVICE ValueAndPushforward<double, double> | |||
| __builtin_exp_pushforward(double x, double d_x) { | |||
There was a problem hiding this comment.
warning: declaration uses identifier '__builtin_exp_pushforward', which is a reserved identifier [bugprone-reserved-identifier]
__builtin_exp_pushforward(double x, double d_x) {
^this fix will not be applied because it overlaps with another fix
| @@ -135,6 +135,11 @@ | |||
| *d_exponent += t.pushforward * d_y; | |||
| } | |||
|
|
|||
| CUDA_HOST_DEVICE ValueAndPushforward<double, double> | |||
| __builtin_exp_pushforward(double x, double d_x) { | |||
There was a problem hiding this comment.
warning: function '__builtin_exp_pushforward' defined in a header file; function definitions in header files can lead to ODR violations [misc-definitions-in-headers]
__builtin_exp_pushforward(double x, double d_x) {
^Additional context
include/clad/Differentiator/BuiltinDerivatives.h:138: make as 'inline'
__builtin_exp_pushforward(double x, double d_x) {
^| @@ -135,6 +135,11 @@ | |||
| *d_exponent += t.pushforward * d_y; | |||
| } | |||
|
|
|||
| CUDA_HOST_DEVICE ValueAndPushforward<double, double> | |||
| __builtin_exp_pushforward(double x, double d_x) { | |||
There was a problem hiding this comment.
warning: invalid case style for function '__builtin_exp_pushforward' [readability-identifier-naming]
__builtin_exp_pushforward(double x, double d_x) {
^this fix will not be applied because it overlaps with another fix
vgvassilev
force-pushed
the
add-llvm-18-osx-ci
branch
from
9e40539
to
c3dd9f6
Compare
| @@ -135,6 +135,11 @@ CUDA_HOST_DEVICE inline void __builtin_powf_pullback(float x, float exponent, | |||
| *d_exponent += t.pushforward * d_y; | |||
| } | |||
|
|
|||
| CUDA_HOST_DEVICE ValueAndPushforward<double, double> | |||
| inline __builtin_exp_pushforward(double x, double d_x) { | |||
There was a problem hiding this comment.
warning: declaration uses identifier '__builtin_exp_pushforward', which is a reserved identifier [bugprone-reserved-identifier]
inline __builtin_exp_pushforward(double x, double d_x) {
^this fix will not be applied because it overlaps with another fix
| @@ -135,6 +135,11 @@ | |||
| *d_exponent += t.pushforward * d_y; | |||
| } | |||
|
|
|||
| CUDA_HOST_DEVICE ValueAndPushforward<double, double> | |||
| inline __builtin_exp_pushforward(double x, double d_x) { | |||
There was a problem hiding this comment.
warning: invalid case style for function '__builtin_exp_pushforward' [readability-identifier-naming]
inline __builtin_exp_pushforward(double x, double d_x) {
^this fix will not be applied because it overlaps with another fix
mcbarton
force-pushed
the
add-llvm-18-osx-ci
branch
from
c3dd9f6
to
be5679c
Compare
This PR adds llvm 18 to the ci for osx