Add llvm 18 osx ci #1025

vgvassilev · 2024-08-04T10:22:25Z

This is the same as #889 but I cannot login to the bots. Let's try if this will let me use tmate...

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-04T10:25:52Z

include/clad/Differentiator/BuiltinDerivatives.h

@@ -135,6 +135,11 @@ CUDA_HOST_DEVICE inline void __builtin_powf_pullback(float x, float exponent,
  *d_exponent += t.pushforward * d_y;
 }

+CUDA_HOST_DEVICE ValueAndPushforward<double, double>
+inline __builtin_exp_pushforward(double x, double d_x) {


warning: declaration uses identifier '__builtin_exp_pushforward', which is a reserved identifier [bugprone-reserved-identifier]

inline __builtin_exp_pushforward(double x, double d_x) { ^

this fix will not be applied because it overlaps with another fix

github-actions · 2024-08-04T10:25:52Z

include/clad/Differentiator/BuiltinDerivatives.h

@@ -135,6 +135,11 @@
  *d_exponent += t.pushforward * d_y;
 }

+CUDA_HOST_DEVICE ValueAndPushforward<double, double>
+inline __builtin_exp_pushforward(double x, double d_x) {


warning: invalid case style for function '__builtin_exp_pushforward' [readability-identifier-naming]

inline __builtin_exp_pushforward(double x, double d_x) { ^

this fix will not be applied because it overlaps with another fix

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-04T18:56:42Z

lib/Differentiator/ReverseModeVisitor.cpp

-        // Silence diag outputs in nested derivation process.
-        pullbackRequest.VerboseDiags = false;
+        // Silence diag outputs in nested derivation process unless we are going
+        // through a builtin function which we know we cannot differentiate.


warning: argument comment missing for literal argument 'val' [bugprone-argument-comment]

Suggested change

// through a builtin function which we know we cannot differentiate.

DerivedCallArgs.front()->getType(), m_Context, /*val=*/1));

github-actions

clang-tidy made some suggestions

include/clad/Differentiator/BuiltinDerivatives.h

codecov · 2024-08-05T14:27:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (3ca7de7) to head (fe4d8a0).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
+ Coverage   94.24%   94.25%   +0.01%     
==========================================
  Files          55       55              
  Lines        8445     8445              
==========================================
+ Hits         7959     7960       +1     
+ Misses        486      485       -1

Files with missing lines	Coverage Δ
include/clad/Differentiator/BuiltinDerivatives.h	`100.00% <ø> (ø)`

... and 2 files with indirect coverage changes

Files with missing lines	Coverage Δ
include/clad/Differentiator/BuiltinDerivatives.h	`100.00% <ø> (ø)`

... and 2 files with indirect coverage changes

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 11. Check the log or trigger a new build to see more.

include/clad/Differentiator/BuiltinDerivatives.h

github-actions · 2024-08-21T06:40:59Z

include/clad/Differentiator/DiffPlanner.h

@@ -43,7 +43,7 @@ struct DiffRequest {
  unsigned RequestedDerivativeOrder = 1;
  /// Context in which the function is being called, or a call to
  /// clad::gradient/differentiate, where function is the first arg.
-  clang::CallExpr* CallContext = nullptr;
+  const clang::CallExpr* CallContext = nullptr;


warning: member variable 'CallContext' has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]

const clang::CallExpr* CallContext = nullptr; ^

github-actions · 2024-08-21T06:40:59Z

lib/Differentiator/DerivativeBuilder.cpp

-               "have a "
-               "definition",
-               {FD->getNameAsString()});
+        if (true || request.VerboseDiags) {


warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]

Suggested change

if (true || request.VerboseDiags) {

if (true) {

github-actions · 2024-08-21T06:40:59Z

lib/Differentiator/DiffPlanner.cpp

@@ -176,7 +176,7 @@ namespace clad {

  void DiffRequest::updateCall(FunctionDecl* FD, FunctionDecl* OverloadedFD,
                               Sema& SemaRef) {
-    CallExpr* call = this->CallContext;
+    CallExpr* call = const_cast<CallExpr*>(this->CallContext);


warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]

CallExpr* call = const_cast<CallExpr*>(this->CallContext); ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-21T07:24:09Z

lib/Differentiator/DiffPlanner.cpp

@@ -176,7 +176,7 @@ namespace clad {

  void DiffRequest::updateCall(FunctionDecl* FD, FunctionDecl* OverloadedFD,
                               Sema& SemaRef) {
-    CallExpr* call = this->CallContext;
+    CallExpr* call = const_cast<CallExpr*>(this->CallContext);


warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]

Suggested change

CallExpr* call = const_cast<CallExpr*>(this->CallContext);

auto* call = const_cast<CallExpr*>(this->CallContext);

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-21T08:18:11Z

include/clad/Differentiator/BuiltinDerivatives.h

@@ -77,6 +77,9 @@ ValueAndPushforward<int, int> cudaDeviceSynchronize_pushforward()
 }
 #endif

+// NOLINTBEGIN(readability-identifier-naming)


warning: unmatched 'NOLINTBEGIN' comment without a subsequent 'NOLINTEND' comment [clang-tidy-nolint]

// NOLINTBEGIN(readability-identifier-naming) ^

include/clad/Differentiator/BuiltinDerivatives.h

github-actions · 2024-08-21T08:18:12Z

include/clad/Differentiator/BuiltinDerivatives.h

 // FIXME: Add the rest of the __builtin_ routines for log, sqrt, abs, etc.

+// NOLINTEND(readability-identifier-naming)


warning: unmatched 'NOLINTEND' comment without a previous 'NOLINTBEGIN' comment [clang-tidy-nolint]

// NOLINTEND(readability-identifier-naming) ^

github-actions · 2024-08-21T08:26:44Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-21T09:31:47Z

include/clad/Differentiator/BuiltinDerivatives.h

+
+CUDA_HOST_DEVICE inline ValueAndPushforward<float, float>
+__builtin_sqrtf_pushforward(float x, float d_x) {
+  return {builtin_sqrtf(x), (((T)1) / (((T)2) * builtin_sqrtf(x))) * d_x};


warning: use of undeclared identifier 'T' [clang-diagnostic-error]

return {builtin_sqrtf(x), (((T)1) / (((T)2) * builtin_sqrtf(x))) * d_x}; ^

github-actions · 2024-08-21T09:31:47Z

include/clad/Differentiator/BuiltinDerivatives.h

+
+CUDA_HOST_DEVICE inline ValueAndPushforward<float, float>
+__builtin_sqrtf_pushforward(float x, float d_x) {
+  return {builtin_sqrtf(x), (((T)1) / (((T)2) * builtin_sqrtf(x))) * d_x};


warning: use of undeclared identifier 'T' [clang-diagnostic-error]

return {builtin_sqrtf(x), (((T)1) / (((T)2) * builtin_sqrtf(x))) * d_x}; ^

github-actions · 2024-08-21T09:31:47Z

include/clad/Differentiator/BuiltinDerivatives.h

+
+CUDA_HOST_DEVICE inline ValueAndPushforward<float, float>
+__builtin_sqrtf_pushforward(float x, float d_x) {
+  return {builtin_sqrtf(x), (((T)1) / (((T)2) * builtin_sqrtf(x))) * d_x};


warning: use of undeclared identifier 'builtin_sqrtf'; did you mean '__builtin_sqrtf'? [clang-diagnostic-error]

Suggested change

return {builtin_sqrtf(x), (((T)1) / (((T)2) * builtin_sqrtf(x))) * d_x};

return {__builtin_sqrtf(x), (((T)1) / (((T)2) * builtin_sqrtf(x))) * d_x};

Additional context

/usr/include/c++/12/cmath:463: '__builtin_sqrtf' declared here

{ return __builtin_sqrtf(__x); } ^

github-actions · 2024-08-21T09:31:47Z

include/clad/Differentiator/BuiltinDerivatives.h

+
+CUDA_HOST_DEVICE inline ValueAndPushforward<float, float>
+__builtin_sqrtf_pushforward(float x, float d_x) {
+  return {builtin_sqrtf(x), (((T)1) / (((T)2) * builtin_sqrtf(x))) * d_x};


warning: use of undeclared identifier 'builtin_sqrtf'; did you mean '__builtin_sqrtf'? [clang-diagnostic-error]

Suggested change

return {builtin_sqrtf(x), (((T)1) / (((T)2) * builtin_sqrtf(x))) * d_x};

return {builtin_sqrtf(x), (((T)1) / (((T)2) * __builtin_sqrtf(x))) * d_x};

Additional context

/usr/include/c++/12/cmath:463: '__builtin_sqrtf' declared here

{ return __builtin_sqrtf(__x); } ^

github-actions · 2024-08-21T09:31:48Z

include/clad/Differentiator/BuiltinDerivatives.h

+
+CUDA_HOST_DEVICE inline ValueAndPushforward<double, double>
+__builtin_sqrt_pushforward(double x, double d_x) {
+  return {builtin_sqrt(x), (((T)1) / (((T)2) * builtin_sqrt(x))) * d_x};


warning: use of undeclared identifier 'T' [clang-diagnostic-error]

return {builtin_sqrt(x), (((T)1) / (((T)2) * builtin_sqrt(x))) * d_x}; ^

github-actions · 2024-08-21T09:31:48Z

include/clad/Differentiator/BuiltinDerivatives.h

+
+CUDA_HOST_DEVICE inline ValueAndPushforward<double, double>
+__builtin_sqrt_pushforward(double x, double d_x) {
+  return {builtin_sqrt(x), (((T)1) / (((T)2) * builtin_sqrt(x))) * d_x};


warning: use of undeclared identifier 'T' [clang-diagnostic-error]

return {builtin_sqrt(x), (((T)1) / (((T)2) * builtin_sqrt(x))) * d_x}; ^

github-actions · 2024-08-21T09:31:48Z

include/clad/Differentiator/BuiltinDerivatives.h

+
+CUDA_HOST_DEVICE inline ValueAndPushforward<double, double>
+__builtin_sqrt_pushforward(double x, double d_x) {
+  return {builtin_sqrt(x), (((T)1) / (((T)2) * builtin_sqrt(x))) * d_x};


warning: use of undeclared identifier 'builtin_sqrt'; did you mean '__builtin_sqrt'? [clang-diagnostic-error]

Suggested change

return {builtin_sqrt(x), (((T)1) / (((T)2) * builtin_sqrt(x))) * d_x};

return {__builtin_sqrt(x), (((T)1) / (((T)2) * builtin_sqrt(x))) * d_x};

Additional context

/usr/include/c++/12/cmath:475: '__builtin_sqrt' declared here

{ return __builtin_sqrt(__x); } ^

github-actions · 2024-08-21T09:31:48Z

include/clad/Differentiator/BuiltinDerivatives.h

+
+CUDA_HOST_DEVICE inline ValueAndPushforward<double, double>
+__builtin_sqrt_pushforward(double x, double d_x) {
+  return {builtin_sqrt(x), (((T)1) / (((T)2) * builtin_sqrt(x))) * d_x};


warning: use of undeclared identifier 'builtin_sqrt'; did you mean '__builtin_sqrt'? [clang-diagnostic-error]

Suggested change

return {builtin_sqrt(x), (((T)1) / (((T)2) * builtin_sqrt(x))) * d_x};

return {builtin_sqrt(x), (((T)1) / (((T)2) * __builtin_sqrt(x))) * d_x};

Additional context

/usr/include/c++/12/cmath:475: '__builtin_sqrt' declared here

{ return __builtin_sqrt(__x); } ^

github-actions · 2024-08-21T09:46:43Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-14T14:15:50Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-16T10:46:41Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-16T11:27:00Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-16T17:39:28Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-16T17:52:43Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-16T18:42:36Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-17T05:42:02Z

clang-tidy review says "All clean, LGTM! 👍"

mcbarton · 2024-10-15T15:29:32Z

@vgvassilev If we can work out how to get this PR passing then I'll look at adding llvm 19 compatibility.

vgvassilev · 2024-10-15T19:01:20Z

@vgvassilev If we can work out how to get this PR passing then I'll look at adding llvm 19 compatibility.

On my todo list... I have everything set up, don't have the time to look at it just yet.

github-actions bot reviewed Aug 4, 2024

View reviewed changes

vgvassilev force-pushed the add-llvm-18-osx-ci branch from 297f428 to 53e1ddf Compare August 5, 2024 14:18

github-actions bot reviewed Aug 5, 2024

View reviewed changes

include/clad/Differentiator/BuiltinDerivatives.h Show resolved Hide resolved

include/clad/Differentiator/BuiltinDerivatives.h Show resolved Hide resolved

vgvassilev force-pushed the add-llvm-18-osx-ci branch from 53e1ddf to e9450fe Compare August 6, 2024 14:58

github-actions bot reviewed Aug 21, 2024

View reviewed changes

vgvassilev force-pushed the add-llvm-18-osx-ci branch from 1fa5a86 to 89454b6 Compare August 21, 2024 07:14

github-actions bot reviewed Aug 21, 2024

View reviewed changes

vgvassilev force-pushed the add-llvm-18-osx-ci branch from 89454b6 to 7bba2aa Compare August 21, 2024 08:14

github-actions bot reviewed Aug 21, 2024

View reviewed changes

vgvassilev force-pushed the add-llvm-18-osx-ci branch from 7bba2aa to 7621c9c Compare August 21, 2024 08:22

github-actions bot reviewed Aug 21, 2024

View reviewed changes

vgvassilev force-pushed the add-llvm-18-osx-ci branch from e6cd81c to 315d4ab Compare August 21, 2024 09:43

vgvassilev and others added 4 commits September 14, 2024 14:01

Add builtin_exp

c601e48

Add exp pullback

3d7a905

Add llvm 18 for osx to ci

ee4ac8d

Add builtin sin, cos, sqrt pushforwards

03b35a1

vgvassilev force-pushed the add-llvm-18-osx-ci branch from 315d4ab to 03b35a1 Compare September 14, 2024 14:10

[ci] Always run the tmate if debug is requested.

04a5d4c

vgvassilev force-pushed the add-llvm-18-osx-ci branch from 3f80bc2 to 04a5d4c Compare September 16, 2024 11:18

vgvassilev force-pushed the add-llvm-18-osx-ci branch from 137133b to b85c9ce Compare September 16, 2024 17:46

vgvassilev force-pushed the add-llvm-18-osx-ci branch from b85c9ce to e65827d Compare September 16, 2024 18:38

vgvassilev added 2 commits September 17, 2024 05:35

Adjust BasicOps.C

6044fa7

[ci] Print more information about the failures.

fe4d8a0

vgvassilev force-pushed the add-llvm-18-osx-ci branch from e65827d to fe4d8a0 Compare September 17, 2024 05:38

	// through a builtin function which we know we cannot differentiate.
	DerivedCallArgs.front()->getType(), m_Context, /val=/1));

	CallExpr* call = const_cast<CallExpr*>(this->CallContext);
	auto* call = const_cast<CallExpr*>(this->CallContext);

		// FIXME: Add the rest of the __builtin_ routines for log, sqrt, abs, etc.

		// NOLINTEND(readability-identifier-naming)

	return {builtin_sqrtf(x), (((T)1) / (((T)2) * builtin_sqrtf(x))) * d_x};
	return {__builtin_sqrtf(x), (((T)1) / (((T)2) * builtin_sqrtf(x))) * d_x};

	return {builtin_sqrt(x), (((T)1) / (((T)2) * builtin_sqrt(x))) * d_x};
	return {__builtin_sqrt(x), (((T)1) / (((T)2) * builtin_sqrt(x))) * d_x};

Add llvm 18 osx ci #1025

Are you sure you want to change the base?

Add llvm 18 osx ci #1025

Conversation

vgvassilev commented Aug 4, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 4, 2024

Choose a reason for hiding this comment

github-actions bot Aug 4, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 4, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 5, 2024 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 21, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 21, 2024

github-actions bot commented Sep 14, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 17, 2024

mcbarton commented Oct 15, 2024 • edited Loading

vgvassilev commented Oct 15, 2024

codecov bot commented Aug 5, 2024 •

edited

Loading

mcbarton commented Oct 15, 2024 •

edited

Loading