Skip to content

Commit

Permalink
Add diags
Browse files Browse the repository at this point in the history
  • Loading branch information
vgvassilev committed Aug 4, 2024
1 parent c3dd9f6 commit 297f428
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,7 @@ jobs:
if: ${{ failure() && runner.debug }}
uses: mxschmitt/action-tmate@v3
# When debugging increase to a suitable value!
timeout-minutes: 30
timeout-minutes: 60
- name: Prepare code coverage report
if: ${{ success() && (matrix.coverage == true) }}
run: |
Expand Down
7 changes: 4 additions & 3 deletions lib/Differentiator/ReverseModeVisitor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1776,8 +1776,9 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context,
pullbackRequest.BaseFunctionName =
clad::utils::ComputeEffectiveFnName(FD);
pullbackRequest.Mode = DiffMode::experimental_pullback;
// Silence diag outputs in nested derivation process.
pullbackRequest.VerboseDiags = false;
// Silence diag outputs in nested derivation process unless we are going
// through a builtin function which we know we cannot differentiate.
pullbackRequest.VerboseDiags = FD->getBuiltinID();
pullbackRequest.EnableTBRAnalysis = m_DiffReq.EnableTBRAnalysis;
bool isaMethod = isa<CXXMethodDecl>(FD);
for (size_t i = 0, e = FD->getNumParams(); i < e; ++i)
Expand All @@ -1803,7 +1804,7 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context,
// it already correctly support reference arguments then confirm the
// support and add tests for the same.
if (!pullbackFD && !utils::HasAnyReferenceOrPointerArgument(FD) &&
!isa<CXXMethodDecl>(FD)) {
!isa<CXXMethodDecl>(FD) && !FD->getBuiltinID()) {
// Try numerically deriving it.
if (NArgs == 1) {
OverloadedDerivedFn = GetSingleArgCentralDiffCall(
Expand Down

0 comments on commit 297f428

Please sign in to comment.