Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deps, add edge support #15

Closed
wants to merge 4 commits into from
Closed

update deps, add edge support #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0edc13
update deps, add edge support
agadzik Aug 23, 2023
f0b0e0f
Add back grpc support for node
agadzik Aug 23, 2023
faec729
Changes made based on feedback
agadzik Sep 6, 2023
64fd6bd
update lockfile
agadzik Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,12 @@ This is all that is needed to trace your app on Vercel or any other platform exp

## 🧪 What exactly is this package doing

This package utilizes the [`exports`](https://nodejs.org/api/packages.html#exports) API, enabling us to import the OpenTelemetry SDK in Node only. When you import `registerOTel` in a file intended for the edge, it returns an empty function because OpenTelemetry doesn't support the edge. However, if you import the same function in a file designed for Node, you'll receive a standard function that sets up the OpenTelemetry SDK correctly.
This package utilizes the [`exports`](https://nodejs.org/api/packages.html#exports) API, enabling us to import the OpenTelemetry SDK in Node and Edge runtimes. When you import `registerOTel`, you'll receive a standard function that sets up the OpenTelemetry SDK correctly.

The OpenTelemetry SDK initialization itself is straightforward. For more details, please see [the code](https://github.com/vercel/otel/blob/main/src/index.node.ts).
The OpenTelemetry SDK initialization itself is straightforward. For more details, please see the code,

- [node](https://github.com/vercel/otel/blob/main/src/index.node.ts)
- [edge](https://github.com/vercel/otel/blob/main/src/index.edge.ts)

## 📄 License

Expand Down
21 changes: 14 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,22 @@
"license": "MIT",
"devDependencies": {
"@types/node": "18.16.1",
"typescript": "^5.0.4"
"typescript": "5.0.4"
},
"dependencies": {
"@opentelemetry/api": "^1.4.1",
"@opentelemetry/exporter-trace-otlp-grpc": "^0.38.0",
"@opentelemetry/resources": "^1.12.0",
"@opentelemetry/sdk-node": "^0.38.0",
"@opentelemetry/sdk-trace-node": "^1.12.0",
"@opentelemetry/semantic-conventions": "^1.12.0"
"@opentelemetry/api": "1.4.1",
"@opentelemetry/context-async-hooks": "1.15.2",
"@opentelemetry/core": "1.15.2",
"@opentelemetry/exporter-trace-otlp-grpc": "0.41.2",
"@opentelemetry/exporter-trace-otlp-http": "0.41.2",
agadzik marked this conversation as resolved.
Show resolved Hide resolved
"@opentelemetry/otlp-exporter-base": "0.41.2",
"@opentelemetry/otlp-transformer": "0.41.2",
"@opentelemetry/resources": "1.15.2",
"@opentelemetry/sdk-node": "0.41.2",
"@opentelemetry/sdk-trace-base": "1.15.2",
"@opentelemetry/sdk-trace-node": "1.15.2",
"@opentelemetry/semantic-conventions": "1.15.2",
"performance-polyfill": "0.0.3"
},
"packageManager": "[email protected]",
"engines": {
Expand Down
Loading