update deps, add edge support #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agadzik
commented
Aug 23, 2023
agadzik
commented
- Updating dependencies to the latest versions
- Adds Edge support for OTEL tracing
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
dvoytenko
requested changes
Aug 24, 2023
dvoytenko
approved these changes
Sep 6, 2023
DavidS-ovm
reviewed
Dec 1, 2023
| method: "POST", | ||
| body: JSON.stringify(serviceRequest), | ||
| headers: { | ||
| "Content-Type": "application/json", |
There was a problem hiding this comment.
without additional headers from OTEL_EXPORTER_OTLP_HEADERS this won't do much for folks.
|
I've copied this into our codebase to test out (including fixing the configuration) but was not able to tickle it to send spans to my collector. |
|
@DavidS-ovm yes. We are doing a major review on this package, so this would likely change significantly. Should have some additional info on this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.