-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pgvector fixes #660
Pgvector fixes #660
Conversation
Fix default embedding model used with PGVector
Removed redundant method declaration in PGVector; update PGVector unit tests
All of @andreped's changes are now merged into this PR and I think it is ready to merge. |
The tests are passing for me, I made a small change to bring in the database port from an environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I commented out the tests because I'm getting a bunch of dependency issues trying to run them. We can add them back later |
No worries, @zainhoda. As we already talked about, I can make a PR to add these tests in a more proper way, such that they will not conflict with the tests you are already running on your end (potentially not in GitHub Actions). You should be able to test individual components easily without the full blown tests. |
Fixes for #659
@andreped could you take a look?