Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pgvector fixes #660

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Pgvector fixes #660

merged 10 commits into from
Oct 23, 2024

Conversation

edlouth
Copy link
Contributor

@edlouth edlouth commented Oct 1, 2024

Fixes for #659

@andreped could you take a look?

@edlouth edlouth mentioned this pull request Oct 1, 2024
@edlouth
Copy link
Contributor Author

edlouth commented Oct 1, 2024

All of @andreped's changes are now merged into this PR and I think it is ready to merge.

@andreped
Copy link
Contributor

andreped commented Oct 1, 2024

All of @andreped's changes are now merged into this PR and I think it is ready to merge.

@edlouth Did you manage to run the pgvector tests? If not, could you do so, to make sure this PR is good?

pytest -v tests/test_pgvector.py

@edlouth
Copy link
Contributor Author

edlouth commented Oct 1, 2024

All of @andreped's changes are now merged into this PR and I think it is ready to merge.

@edlouth Did you manage to run the pgvector tests? If not, could you do so, to make sure this PR is good?

pytest -v tests/test_pgvector.py

The tests are passing for me, I made a small change to bring in the database port from an environment variable.

@andreped
Copy link
Contributor

andreped commented Oct 1, 2024

The tests are passing for me, I made a small change to bring in the database port from an environment variable.

Great! Then I think PR is good!

Still requires approval from @zainhoda before merge though, but great job, @edlouth! :]

Copy link
Contributor

@andreped andreped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zainhoda
Copy link
Contributor

I commented out the tests because I'm getting a bunch of dependency issues trying to run them. We can add them back later

@zainhoda zainhoda merged commit ac1a841 into vanna-ai:main Oct 23, 2024
@edlouth edlouth deleted the pgvector_fixes branch October 23, 2024 13:18
@andreped
Copy link
Contributor

No worries, @zainhoda. As we already talked about, I can make a PR to add these tests in a more proper way, such that they will not conflict with the tests you are already running on your end (potentially not in GitHub Actions).

You should be able to test individual components easily without the full blown tests.

@zainhoda zainhoda linked an issue Oct 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PG Vector not working
3 participants