Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run npm install with --legacy-peer-deps for React 19 #20829

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: Run npm install with --legacy-peer-deps for React 19 #20829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskRunNpmInstall.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import org.apache.commons.io.FileUtils;
import org.slf4j.Logger;

import com.vaadin.experimental.FeatureFlags;
import com.vaadin.flow.internal.Pair;
import com.vaadin.flow.server.Constants;
import com.vaadin.flow.server.ExecutionFailedException;
Expand Down Expand Up @@ -267,6 +268,9 @@ private void runNpmInstall() throws ExecutionFailedException {
}

npmInstallCommand.add("--ignore-scripts");
if (options.getFeatureFlags().isEnabled(FeatureFlags.REACT19)) {
npmInstallCommand.add(" --legacy-peer-deps");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarity this could have a comment that should/can be removed after Lit x.y.z has been released and taken into use.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new lit release so maybe we don’t need this pr at all

}

if (options.isCiBuild()) {
if (options.isEnablePnpm() || options.isEnableBun()) {
Expand Down
Loading