chore: Run npm install with --legacy-peer-deps for React 19 #20829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
changed the title
Needed until there is a new Lit release
Artur-
force-pushed
the
react19-legacy-peer-deps
branch
from
b3f9e13 to
39f17b0
Compare
|
mshabarov
approved these changes
Jan 10, 2025
caalador
reviewed
Jan 10, 2025
| @@ -267,6 +268,9 @@ private void runNpmInstall() throws ExecutionFailedException { | |||
| } | |||
|
|
|||
| npmInstallCommand.add("--ignore-scripts"); | |||
| if (options.getFeatureFlags().isEnabled(FeatureFlags.REACT19)) { | |||
| npmInstallCommand.add(" --legacy-peer-deps"); | |||
There was a problem hiding this comment.
Just for clarity this could have a comment that should/can be removed after Lit x.y.z has been released and taken into use.
There was a problem hiding this comment.
There is a new lit release so maybe we don’t need this pr at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed until there is a new Lit release