Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitch bms refactor #287

Merged
merged 12 commits into from
Jun 17, 2024
Merged

Mitch bms refactor #287

merged 12 commits into from
Jun 17, 2024

Conversation

mitchellostler
Copy link
Collaborator

Add retries, fix afe timing, update thermistors to use the aux bitset
Add AFE logging for the display

Copy link
Member

@Akashem06 Akashem06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

return STATUS_CODE_OK;
persist_init(&s_persist, CURRENT_SENSE_STORE_FLASH, &s_fuel_params, sizeof(s_fuel_params), false);
// status = max17261_init(&s_fuel_guage_storage, &s_fuel_gauge_settings, &s_fuel_params);
// tasks_init_task(current_sense, TASK_PRIORITY(2), NULL);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment?

@Akashem06 Akashem06 merged commit bb14e1a into main Jun 17, 2024
1 check passed
@Akashem06 Akashem06 deleted the mitch_bms_refactor branch June 17, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants