Pd cc bms mci changes (new boards + new fsm) #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akashem06
force-pushed
the
pd_cc_bms_mci_changes
branch
from
13270f6
to
921ffad
Compare
| state = ((val2 & 8) != 0) ? GPIO_STATE_HIGH : GPIO_STATE_LOW; | ||
| gpio_set_state(&display->D2, state); | ||
| // state = ((val2 & 8) != 0) ? GPIO_STATE_HIGH : GPIO_STATE_LOW; | ||
| // gpio_set_state(&display->D2, state); |
There was a problem hiding this comment.
These need the un-remap right?
There was a problem hiding this comment.
yesh from what i understand debug logging uses PB7 (d2) which is already a remapped pin. Disabling the remap wont work either since those pins are used too (PA8/PA9 on datasheet). Maybe a smoke test without any logging/uart implementation would be useful to verify this? I do have a seg_display smoke but log is being initialized there. Best workaround for the future is probably asking Forest to remove that pin from the schematic so its never used again 😭
mitchellostler
approved these changes
May 4, 2024
mitchellostler
force-pushed
the
pd_cc_bms_mci_changes
branch
from
e34c274
to
25273b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.