Fwxv 999 ejramas 103 hw #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bafran
reviewed
Mar 27, 2024
|
|
||
| void run_fast_cycle() {} | ||
|
|
||
| int increment(int i) { |
There was a problem hiding this comment.
You don't necessarily need this function to increment your variable, you can just have that in your task
|
|
||
| TASK(task1, TASK_STACK_512) { | ||
| StatusCode ret; | ||
| u_int32_t to_send = 0; |
There was a problem hiding this comment.
did you mean to increment this variable?
|
|
||
| TASK(task1, TASK_STACK_512) { | ||
| LOG_DEBUG("Task 1 starting\n\n"); | ||
| GpioAddress addr1 = { |
There was a problem hiding this comment.
Nitpick: initializing this in an array would be better
| .pin = 15, | ||
| }; | ||
|
|
||
| gpio_init_pin(&addr1, GPIO_OUTPUT_PUSH_PULL, GPIO_STATE_HIGH); |
There was a problem hiding this comment.
The initializations and the toggles could be done in a for loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.