Pd rev2 fixes #258
Merged
Pd rev2 fixes #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellostler
requested changes
Jan 28, 2024
There was a problem hiding this comment.
Just the one change. I saw you also have your Power FSM changes up, but it looks like they're in this PR too. If you address the comments on that PR here, we can merge this one and close the other, or we can merge that one first and then you can resolve conflicts, up to you.
| @@ -4,6 +4,12 @@ | |||
| #include "outputs.h" | |||
| #include "power_distribution_getters.h" | |||
|
|
|||
| #define brake_lights() \ | |||
There was a problem hiding this comment.
Not a huge fan of this syntax. I think it would be better to just make it a short prv_ function
Bafran
reviewed
Feb 3, 2024
| @@ -72,14 +72,6 @@ static void prv_on_state_output(void *context) { | |||
|
|
|||
| static void prv_on_state_input(Fsm *fsm, void *context) { | |||
| pd_fault_ok_or_transition(fsm); | |||
| if (power_context.target_state == POWER_STATE_OFF) { | |||
There was a problem hiding this comment.
why did this logic get removed?
mitchellostler
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.