Mc integration test #230
Merged
Mc integration test #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiCheng-Lu
commented
Nov 6, 2023
ShiCheng-Lu
commented
Nov 6, 2023
ShiCheng-Lu
commented
Nov 6, 2023
ShiCheng-Lu
commented
Nov 6, 2023
ShiCheng-Lu
force-pushed
the
mc-integration-test
branch
from
871dd39
to
1670a3b
Compare
JarvisWeng
reviewed
Jan 25, 2024
Kyle02
reviewed
Mar 7, 2024
| for (size_t tx = 0; tx < len; tx++) { | ||
| if (queue_receive(&s_port[spi].spi_buf.tx_queue, &data[tx], SPI_QUEUE_DELAY_MS)) { | ||
| if (queue_receive(&s_port[spi].spi_buf.tx_queue, &data[tx], SPI_TIMEOUT_MS)) { |
There was a problem hiding this comment.
why did this change, didnt you update SPI_QUEUE_DELAY_MS earlier? from 0 to 10
There was a problem hiding this comment.
match arm impl
JarvisWeng
reviewed
Mar 23, 2024
* fix cur/vel flipped * test * revert steering.yaml --------- Co-authored-by: Bafran <[email protected]>
Bafran
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Lots of really useful changes here. Not sure what's going on with the LED test changes? Also I really didn't look through the motor controller tests and python files since it shouldn't really affect anything. Only other comments were pretty much the same ones that Kyle had
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.