Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current sense for solar sense #210

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

ay0fasan
Copy link
Contributor

No description provided.

projects/solar_sense/src/current_sense.c Show resolved Hide resolved
projects/solar_sense/src/current_sense.c Outdated Show resolved Hide resolved
projects/solar_sense/src/current_sense.c Outdated Show resolved Hide resolved
projects/solar_sense/inc/current_sense.h Outdated Show resolved Hide resolved
projects/solar_sense/src/current_sense.c Outdated Show resolved Hide resolved
projects/solar_sense/src/current_sense.c Outdated Show resolved Hide resolved
projects/solar_sense/src/current_sense.c Outdated Show resolved Hide resolved
projects/solar_sense/inc/current_sense.h Show resolved Hide resolved
Copy link
Collaborator

@ShiCheng-Lu ShiCheng-Lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if you could test this (if i2c is mockable), then it would be nice to have some tests for it, otherwise looks good.

@ShiCheng-Lu ShiCheng-Lu merged commit c264fb6 into main Oct 19, 2023
1 check passed
@ShiCheng-Lu ShiCheng-Lu deleted the FWXV_227_Current_Sense_for_Solar_Sense branch October 19, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants