Clamp down expected outputs. #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@tkphd, the new version of the PFHub website is available at https://random-cat-1499.surge.sh |
tkphd
force-pushed
the
upload-specifications
branch
from
439349c to
486e5d2
Compare
|
@tkphd, the new version of the PFHub website is available at https://random-cat-1499.surge.sh |
wd15
reviewed
Mar 17, 2023
benchmarks/benchmark1.ipynb
Outdated
| @@ -1001,13 +1001,57 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
- We will need to remember to update the link to the upload pages when we have those updated. Keep that link for now as it at least links to the old-old upload method.
- "This data can be uploaded directly to the website ..." is obviously not correct, but this will need to updated across all the notebooks when we create the then upload documentation. Maybe remove this for now. [Edit: let's keep it, but remove "upload directly to website as that facilitly is no longer availabe -- note that we will have to modify this wording across all the benchmarks once we've got Zenodo uploads working fully]
- "... in a file named needs to be ..." doesn't make sense
- "This CSV file" -> "The CSV file"
- "CSV file" could be a link to the actual CSV formatting spec on wikipedia or something
- "we shall endeavor" -> the PFHub team or the PFHub operation
- "The same data as" -> "The same data files as in"
Reply via ReviewNB
There was a problem hiding this comment.
Agreed, except that "this CSV file" is correct.
|
@tkphd: few changes required |
|
@tkphd, the new version of the PFHub website is available at https://random-cat-1499.surge.sh |
Use shell-surge as the environment for BM1 as the shell.nix is missing skimage. shell-surge.nix will replace shell.nix in future when all functionality has been implemented in shell-surge.nix.
|
@tkphd, the new version of the PFHub website is available at https://random-cat-1499.surge.sh |
|
Successful teardown of random-cat-1499.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1229.