fix(website): gitops deployment was missing chainId #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mjlescano
changed the title
mjlescano
force-pushed
the
fix-website-build
branch
from
a938543
to
99400f6
Compare
mjlescano
force-pushed
the
fix-website-build
branch
from
99400f6
to
e13d4cf
Compare
mjlescano
force-pushed
the
fix-website-build
branch
from
96fd2a7
to
13abe12
Compare
dbeal-eth
requested changes
Sep 15, 2024
dbeal-eth
approved these changes
Sep 15, 2024
| const [isBuilding, setIsBuilding] = useState(false); | ||
| const [buildStatus, setBuildStatus] = useState(''); | ||
| const [buildMessage, setBuildMessage] = useState(''); | ||
| const [buildStatus, setBuildStatus] = useState<'idle' | 'building' | 'success' | 'error'>('idle'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the gitops deployment page, by doing the actual fix first, and also fixing the types on the builder so this kind of error is less likely.
chainIdto be consistent with old deployments, kinda like a migration: 9c6c542