fix: chainId init

usecannon · Sep 14, 2024 · a938543 · a938543
1 parent 8871e2c
commit a938543
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/packages/builder/src/runtime.ts b/packages/builder/src/runtime.ts
@@ -88,11 +88,6 @@ export class CannonStorage extends EventEmitter {
 
     const deployInfo: DeploymentInfo = await this.readBlob(uri);
 
-    // Some old packages do not have the chainId saved in artifacts and it is expected
-    if (!deployInfo.chainId) {
-      deployInfo.chainId = chainId;
-    }
-
     return deployInfo;
   }
 

diff --git a/packages/builder/src/types.ts b/packages/builder/src/types.ts
@@ -254,7 +254,7 @@ export type DeploymentInfo = {
   miscUrl: string;
 
   // EVM chain which this deployment is for
-  chainId?: number;
+  chainId: number;
 };
 
 export type DeploymentManifest = {

diff --git a/packages/website/src/features/Deploy/QueueFromGitOpsPage.tsx b/packages/website/src/features/Deploy/QueueFromGitOpsPage.tsx
@@ -43,7 +43,11 @@ import {
   Stack,
 } from '@chakra-ui/react';
 import { useConnectModal } from '@rainbow-me/rainbowkit';
-import { ChainBuilderContext, PackageReference } from '@usecannon/builder';
+import {
+  ChainBuilderContext,
+  PackageReference,
+  DeploymentInfo,
+} from '@usecannon/builder';
 import _ from 'lodash';
 import NextLink from 'next/link';
 import { useRouter } from 'next/navigation';
@@ -255,15 +259,16 @@ function QueueFromGitOps() {
   const uploadToPublishIpfs = useCannonWriteDeployToIpfs(
     buildInfo.buildResult?.runtime,
     cannonDefInfo.def
-      ? {
+      ? ({
           generator: `cannon website ${pkg.version}`,
           timestamp: Math.floor(Date.now() / 1000),
           def: cannonDefInfo.def.toJson(),
           state: buildInfo.buildResult?.state || {},
           options: prevCannonDeployInfo.pkg?.options || {},
           meta: prevCannonDeployInfo.pkg?.meta,
           miscUrl: prevCannonDeployInfo.pkg?.miscUrl || '',
-        }
+          chainId,
+        } satisfies DeploymentInfo)
       : undefined,
     prevCannonDeployInfo.metaUrl
   );